1348453 - Add a single argument overload to ImageBitmap::ExtensionsEnabled()

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Comment 1

[(no longer active)]

Attachment: Add a single argument overload to ImageBitmap::ExtensionsEnabled()

Comment 2

[Andrea Marchesini [:baku]]

Comment on attachment 8848679 [details] [diff] [review]
Add a single argument overload to ImageBitmap::ExtensionsEnabled()

Review of attachment 8848679 [details] [diff] [review]:
-----------------------------------------------------------------

Is this not the same to change:

static bool ExtensionsEnabled(JSContext* aCx, JSObject* aObj = nullptr);

I don't see big differences between your patch and this line.

Comment 3

[(no longer active)]

I'd honestly prefer the default arg myself, but I did what Boris asked me to.  What do you think, Boris?

Comment 4

[Boris Zbarsky [:bzbarsky]]

I can live with the default arg as long as we clearly document that it's totally unused and only there because bindings insist on passing it, and that anyone else should call this function with only one arg.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8bb4f514012b
Make the second argument to ImageBitmap::ExtensionsEnabled() optional; r=baku

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8bb4f514012b