1348532 - chrome://mozapps/content/extensions/list.xul doesn't seem to be used

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement, P2)

Description

[Florian Quèze [:florian]]

I can't find any reference to chrome://mozapps/content/extensions/list.xul, is this dead code we should remove?

Comment 1

[Robert Helmer [:rhelmer]]

It looks like this was changed to blocklist.xul in bug 455906 but wasn't actually removed.

I'm not sure why list.xul was changed in that patch since all links to it were removed... it may have just been an oversight.

Comment 2

[Robert Helmer [:rhelmer]]

(In reply to Robert Helmer [:rhelmer] from comment #1)
> It looks like this was changed to blocklist.xul in bug 455906 but wasn't
> actually removed.
> 
> I'm not sure why list.xul was changed in that patch since all links to it
> were removed... it may have just been an oversight.

Mossop could you confirm that is correct and it's OK to remove chrome://mozapps/content/extensions/list.xul now?

Comment 3

[Dave Townsend [:mossop]]

(In reply to Robert Helmer [:rhelmer] from comment #2)
> (In reply to Robert Helmer [:rhelmer] from comment #1)
> > It looks like this was changed to blocklist.xul in bug 455906 but wasn't
> > actually removed.
> > 
> > I'm not sure why list.xul was changed in that patch since all links to it
> > were removed... it may have just been an oversight.
> 
> Mossop could you confirm that is correct and it's OK to remove
> chrome://mozapps/content/extensions/list.xul now?

My memories from nine years ago are pretty fuzzy so I'm just going to shrug at this. It looks unused so lets delete it.

Comment 4

[Andrew Swan [:aswan]]

Attachment: Bug 1348532 Remove unused list.xul

Review commit: https://reviewboard.mozilla.org/r/123554/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/123554/

Comment 5

[Andrew Swan [:aswan]]

This is just bc tests on linux, I'm open to suggestions for other tests that should be run before landing this:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d43e6b5d417eae0d69bded9550019705ccc300a6

Comment 6

[Dave Townsend [:mossop]]

Comment on attachment 8851190 [details]
Bug 1348532 Remove unused list.xul

https://reviewboard.mozilla.org/r/123554/#review126428

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46b03053823a
Remove unused list.xul r=mossop

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/46b03053823a