Closed Bug 1348545 Opened 9 years ago Closed 9 years ago

stylo: make Gecko_LoadStyleSheet take a stylesheet parameter, remove Servo_ImportRule_GetSheet

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED WORKSFORME
Tracking Flags:
Tracking Status
firefox55 --- affected

People

(Reporter: SimonSapin, Unassigned)

References

(Blocks 1 open bug)

Details

The Gecko_LoadStyleSheet function takes a RawServoImportRuleBorrowed parameter. The only thing it does with it is (eventually) call Servo_ImportRule_GetSheet to obtain RawServoStyleSheetStrong. We can change that parameter to be RawServoStyleSheetStrong in the first place. This would save an FFI call and a RwLock acquire + release whenever an `@import` rule is parsed. We can then remove the Servo_ImportRule_GetSheet function, since it has no other caller.
Summary: Make Gecko_LoadStyleSheet take a stylesheet parameter, remove Servo_ImportRule_GetSheet → stylo: make Gecko_LoadStyleSheet take a stylesheet parameter, remove Servo_ImportRule_GetSheet
Priority: P5 → P4
This has been done in bug 1352763 part 2 because otherwise there would be a nested lock acquiring when inserting @import rule via CSSOM. The Servo_ImportRule_GetSheet is not removed, because I guess I may need it for bug 1352968. If it ends up not being used, I'll remove it there. So closing this bug.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.