1348689 - stylo: layout/reftests/bugs/315920-18b.html started to fail after the changes from bug 1341642.

Status: RESOLVED WORKSFORME

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Emilio Cobos Álvarez [:emilio]]

Stylo now incorrectly renders the text as red.

Comment 1

[Manish Goregaokar [:manishearth]]

I think it was failing before those changes too, at least, it's failing for me on a build without those changes.

Comment 2

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Oh, I've changed the test expectations after a try run in this changeset: https://hg.mozilla.org/mozilla-central/rev/f34476fa83fa But it looks like it was a intermittent test pass after all. I can undo that.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

So in bug 1341642 I said I suspected of bug 1338982 as the reason for the failure. I take that back. Running the test with the following patch:

diff --git a/layout/reftests/bugs/315920-18b.html b/layout/reftests/bugs/315920-18b.html
index 37e46efc1a5d..902e57b694a3 100644
--- a/layout/reftests/bugs/315920-18b.html
+++ b/layout/reftests/bugs/315920-18b.html
@@ -11,4 +11,10 @@
     <img src="no-such-scheme:nothing" id="ffximage"/>
     <label for="ffximage">Text should be green</label>
   </body>
+<script>
+  window.onload = function() {
+    document.querySelector('style').innerHTML += "img { color: invalid; }";
+    document.documentElement.offsetTop;
+  }
+</script>
 </html>

Which should make us re-run selector-matching on the label again, still shows red.

It seems like this should pass after the changes of bug 1341642, but it doesn't.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

We should really go through all the reftests there that check :-moz-broken and still fail, which are a few, and see why they're exactly failing. Then fix them, or find coherent reasons for why it fails and annotate them pointing to bugs.

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

This one looks like it is already passing and enabled by default [1]. I tried all :moz-broken tests I found [2] and they all seem to pass as well. So I am closing this one as works-for-me.

[1] https://dxr.mozilla.org/mozilla-central/source/layout/reftests/bugs/reftest.list?q=315920-18b.htm&redirect_type=single#388
[2] https://dxr.mozilla.org/mozilla-central/search?q=%3A-moz-broken