1348716 - Copy link in CustomTabsActivity by long-clicking in Title

Status: VERIFIED FIXED

(Firefox for Android :: General, enhancement)

Description

[Julian Chu [:walkingice]]

A feature to implement. If user long-click title of ActionBar, we should copy current page link to clipboard and give a prompt 'URL Copied'

Comment 1

[Julian Chu [:walkingice]]

Attachment: Bug 1348716 - Long click to copy URL in custom tabs

If user long click text area of ActionBar(URL or Title), then copy
current URL to clipboard.

Review commit: https://reviewboard.mozilla.org/r/123474/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/123474/

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8850975 [details]
Bug 1348716 - Long click to copy URL in custom tabs

https://reviewboard.mozilla.org/r/123474/#review125910

::: mobile/android/base/java/org/mozilla/gecko/customtabs/CustomTabsActivity.java:468
(Diff revision 1)
> +                Toast.makeText(getContext(),
> +                        R.string.custom_tabs_toast_url_copy,
> +                        Toast.LENGTH_SHORT)
> +                        .show();

We replaced most of our toasts with Snackbar. Consider using our SnackbarBuilder class (but this is something for UX to decide).

::: mobile/android/base/locales/en-US/android_strings.dtd:289
(Diff revision 1)
>  <!ENTITY pref_custom_tabs_summary3 "Allow apps to open websites using a customized version of &brandShortName;">
>  <!-- Localization note (custom_tabs_menu_item_open_in): The variable is replaced by the name of
>       default browser from user's preference, such as "Open in Firefox" -->
>  <!ENTITY custom_tabs_menu_item_open_in "Open in &formatS;">
>  <!ENTITY custom_tabs_menu_footer "Powered by &brandShortName;">
> +<!ENTITY custom_tabs_toast_url_copy "URL copied">

Please add a localization note describing when and how this string is disabled so that our translators know the context of this string.

Comment 3

[Julian Chu [:walkingice]]

Comment on attachment 8850975 [details]
Bug 1348716 - Long click to copy URL in custom tabs

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/123474/diff/1-2/

Comment 4

[Julian Chu [:walkingice]]

Comment on attachment 8850975 [details]
Bug 1348716 - Long click to copy URL in custom tabs

https://reviewboard.mozilla.org/r/123474/#review125910

> We replaced most of our toasts with Snackbar. Consider using our SnackbarBuilder class (but this is something for UX to decide).

OK! That's my bad. I asked designer and he said using Snackbar is good. Updated.

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8850975 [details]
Bug 1348716 - Long click to copy URL in custom tabs

https://reviewboard.mozilla.org/r/123474/#review126768

Yay! \o/

::: mobile/android/base/java/org/mozilla/gecko/customtabs/CustomTabsActivity.java:22
(Diff revision 2)
>  import android.os.Bundle;
>  import android.support.annotation.ColorInt;
>  import android.support.annotation.NonNull;
>  import android.support.annotation.StyleRes;
>  import android.support.annotation.VisibleForTesting;
> +import android.support.design.widget.Snackbar;

nit: This import might be unused? (But I didn't verify)

Comment 6

[Julian Chu [:walkingice]]

Comment on attachment 8850975 [details]
Bug 1348716 - Long click to copy URL in custom tabs

https://reviewboard.mozilla.org/r/123474/#review126768

> nit: This import might be unused? (But I didn't verify)

Thanks. I'd use Snackbar.LENGTH_SHORT as duration :-)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35b016df8beb
Long click to copy URL in custom tabs r=sebastian

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/35b016df8beb

Comment 9

[Sorina Florean [:sflorean]]

Verified as fixed in build 55.0a1 (2017-04-02), by long click on a URL a snackbar is displayed with the following message "URL copied". 
Device: Huawei Honor (Android 5.1.1).