1348755 - Turn on 'layers.advanced.outline-layers' by default

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Ethan Lin[:ethlin]]

After fixing the clip problem, there are few failures now. I think it's not hard to turn it on by default.

Comment 1

[Ethan Lin[:ethlin]]

Attachment: Part1. handle clip region

We should handle clip region for nsDisplayOutline in CreateWebRenderCommands.

Comment 2

[Ethan Lin[:ethlin]]

Attachment: Part2. Add DisplayItemLayerProperties

I add DisplayItemLayerProperties for DisplayItemLayer in this patch. This way cannot completely fix invalidate region problem, but it works for some reftests which have visible region change. Bug 1348414 may have a more comprehensive way to fix this problem.

Comment 3

[Ethan Lin[:ethlin]]

Attachment: Part3. turn on pref and set fuzzy-if for some reftests

Comment 4

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8849420 [details] [diff] [review]
Part2. Add DisplayItemLayerProperties

Review of attachment 8849420 [details] [diff] [review]:
-----------------------------------------------------------------

Can we wait until Mason looks into the other solution?

This isn't going to catch a lot of cases, and I don't see the advantage to landing this (and marking reftests), when it's all going to change again soon.

Comment 5

[Ethan Lin[:ethlin]]

(In reply to Matt Woodrow (:mattwoodrow) from comment #4)
> Comment on attachment 8849420 [details] [diff] [review]
> Part2. Add DisplayItemLayerProperties
> 
> Review of attachment 8849420 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Can we wait until Mason looks into the other solution?
> 
> This isn't going to catch a lot of cases, and I don't see the advantage to
> landing this (and marking reftests), when it's all going to change again
> soon.

Okay, I think I can set the reftest to fails-if since there is only one test has this problem.

Comment 6

[Ethan Lin[:ethlin]]

Attachment: Part2. turn on pref and set fuzzy-if for some reftests

With the fix in bug 1348414, we don't need to add DisplayItemLayerProperties. So I just need to add some fuzzy-if to turn on it by default.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8850428 [details] [diff] [review]
Part2. turn on pref and set fuzzy-if for some reftests

Review of attachment 8850428 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/libpref/init/all.js
@@ +5641,5 @@
>  // Set advanced layers preferences here.
>  pref("layers.advanced.border-layers", false);
>  #ifdef MOZ_ENABLE_WEBRENDER
>  pref("layers.advanced.caret-layers", true);
> +pref("layers.advanced.outline-layers", true);

Note that bug 1349949 is now on the graphics branch, so you'll need to rebase this on top of that. Set the value to 2 here in all.js, and change gfxPrefs.h to use DECL_OVERRIDE_PREF instead of DECL_GFX_PREF.

Comment 8

[Ethan Lin[:ethlin]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #7)
> Comment on attachment 8850428 [details] [diff] [review]
> Part2. turn on pref and set fuzzy-if for some reftests
> 
> Review of attachment 8850428 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: modules/libpref/init/all.js
> @@ +5641,5 @@
> >  // Set advanced layers preferences here.
> >  pref("layers.advanced.border-layers", false);
> >  #ifdef MOZ_ENABLE_WEBRENDER
> >  pref("layers.advanced.caret-layers", true);
> > +pref("layers.advanced.outline-layers", true);
> 
> Note that bug 1349949 is now on the graphics branch, so you'll need to
> rebase this on top of that. Set the value to 2 here in all.js, and change
> gfxPrefs.h to use DECL_OVERRIDE_PREF instead of DECL_GFX_PREF.

Okay, thanks for the reminder.

Comment 9

[Ethan Lin[:ethlin]]

try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7683c56c7ed51e0e5a7cf6b86c6dc2e4b188c1b8

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/0ad88ea3096b
Part1. Handle clipping region for nsDisplayOutline. r=mattwoodrow
https://hg.mozilla.org/projects/graphics/rev/e68abb7ad48a
Part2. Turn the pref on by default and set fuzzy for some reftests. r=mattwoodrow

Comment 11

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/0ad88ea3096b
https://hg.mozilla.org/mozilla-central/rev/e68abb7ad48a