1348873 - Stylo: Change ServoType to uint64_t instead of uint16_t in EventStates

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P1)

Description

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

After adding more flags to stylo(bug 1341642) we needed to change this to be able to return >16bit flags but forgot to do that in the previous bug. We should fix it.

Comment 1

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1348873 - Change ServoType to uint64_t instead of uint16_t in EventStates

Review commit: https://reviewboard.mozilla.org/r/121972/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/121972/

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8849146 [details]
Bug 1348873 - Change ServoType to uint64_t instead of uint16_t in EventStates

https://reviewboard.mozilla.org/r/121972/#review123968

r=me, but you need to also update the bindings in Servo.

Comment 3

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Comment on attachment 8849146 [details]
Bug 1348873 - Change ServoType to uint64_t instead of uint16_t in EventStates

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/121972/diff/1-2/

Comment 4

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Updated the Servo bindings in this PR: https://github.com/servo/servo/pull/16047. We can land this now.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8583f86a7ac2
Change ServoType to uint64_t instead of uint16_t in EventStates r=emilio

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8583f86a7ac2