Closed Bug 1348960 Opened 3 years ago Closed 3 years ago

Cmd / Ctrl + Click to open link in new tab fails with RDM on

Categories

(DevTools :: Responsive Design Mode, defect, P2)

defect

Tracking

(firefox55 affected, firefox58 fixed)

RESOLVED FIXED
Firefox 58
Tracking Status
firefox55 --- affected
firefox58 --- fixed

People

(Reporter: jryans, Assigned: jryans)

References

Details

(Whiteboard: [rdm-v2])

Attachments

(1 file)

STR:

1. Open RDM for some page with links
2. Cmd + Click (Mac) / Ctrl + Click (Windows, Linux) to open some link in a new tab within the RDM viewport

ER:

The new tab should open.

AR:

Nothing happens.  An error is logged to Browser Console:

TypeError: window.openLinkIn is not a function ContentClick.jsm:96:5
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Comment on attachment 8915022 [details]
Bug 1348960 - Expose openLinkIn for RDM tabs.

https://reviewboard.mozilla.org/r/186288/#review191312

::: devtools/client/responsive.html/test/browser/browser_cmd_click.js:26
(Diff revision 1)
> +  let newTab = BrowserTestUtils.waitForNewTab(gBrowser, TAB_URL);
> +  BrowserTestUtils.synthesizeMouseAtCenter("a", {
> +    ctrlKey: true,
> +    metaKey: true,
> +  }, ui.getViewportBrowser());
> +  ok(yield newTab, "New tab opened from link");

Shouldn't you close the tab, or is this done by head file?
Attachment #8915022 - Flags: review?(poirot.alex) → review+
Comment on attachment 8915022 [details]
Bug 1348960 - Expose openLinkIn for RDM tabs.

https://reviewboard.mozilla.org/r/186288/#review191312

> Shouldn't you close the tab, or is this done by head file?

shared-head.js has a kind of fallback for it:

http://searchfox.org/mozilla-central/rev/e62604a97286f49993eb29c493672c17c7398da9/devtools/client/framework/test/shared-head.js#123-127

But, it's probably better to do it directly for completeness...?  I'll add it.
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/891602480e23
Expose openLinkIn for RDM tabs. r=ochameau
https://hg.mozilla.org/mozilla-central/rev/891602480e23
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
I have reproduced this bug with Nightly 55.0a1 (2017-03-20)on Windows 10, 64 Bit!

This bug's fix is verified with latest Beta!

Build ID   : 20171218174357
User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
QA Whiteboard: [bugday-20171227]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.