1348960 - Cmd / Ctrl + Click to open link in new tab fails with RDM on

Status: RESOLVED FIXED

(DevTools :: Responsive Design Mode, defect, P2)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

STR:

1. Open RDM for some page with links
2. Cmd + Click (Mac) / Ctrl + Click (Windows, Linux) to open some link in a new tab within the RDM viewport

ER:

The new tab should open.

AR:

Nothing happens.  An error is logged to Browser Console:

TypeError: window.openLinkIn is not a function ContentClick.jsm:96:5

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1348960 - Expose openLinkIn for RDM tabs.

Review commit: https://reviewboard.mozilla.org/r/186288/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/186288/

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bfafcdae9d3877491639a58f6f1342ff84dcf150

Comment 4

[Alexandre Poirot [:ochameau]]

Comment on attachment 8915022 [details]
Bug 1348960 - Expose openLinkIn for RDM tabs.

https://reviewboard.mozilla.org/r/186288/#review191312

::: devtools/client/responsive.html/test/browser/browser_cmd_click.js:26
(Diff revision 1)
> +  let newTab = BrowserTestUtils.waitForNewTab(gBrowser, TAB_URL);
> +  BrowserTestUtils.synthesizeMouseAtCenter("a", {
> +    ctrlKey: true,
> +    metaKey: true,
> +  }, ui.getViewportBrowser());
> +  ok(yield newTab, "New tab opened from link");

Shouldn't you close the tab, or is this done by head file?

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8915022 [details]
Bug 1348960 - Expose openLinkIn for RDM tabs.

https://reviewboard.mozilla.org/r/186288/#review191312

> Shouldn't you close the tab, or is this done by head file?

shared-head.js has a kind of fallback for it:

http://searchfox.org/mozilla-central/rev/e62604a97286f49993eb29c493672c17c7398da9/devtools/client/framework/test/shared-head.js#123-127

But, it's probably better to do it directly for completeness...?  I'll add it.

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8915022 [details]
Bug 1348960 - Expose openLinkIn for RDM tabs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/186288/diff/1-2/

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4814acf9ce3b9b28a4a7d93dc22ce77a7460e83e

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8173c7fce3b2b2d4fe14aaef13049b1830f13e8e

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/891602480e23
Expose openLinkIn for RDM tabs. r=ochameau

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/891602480e23

Comment 11

[Md Maruf Rahman]

I have reproduced this bug with Nightly 55.0a1 (2017-03-20)on Windows 10, 64 Bit!

This bug's fix is verified with latest Beta!

Build ID   : 20171218174357
User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0