1349008 - SystemGroup used undefined in GMPVideoEncoderParent.cpp

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

I get a build error in GMPVideoEncoderParent.cpp after Bug 1346681 landed due to unified build fuzz:

13:53.01 c:/Users/chris/src/central/dom/media/gmp/GMPVideoEncoderParent.cpp(263): error C2653: 'SystemGroup': is not a class or namespace name
13:53.01 c:/Users/chris/src/central/dom/media/gmp/GMPVideoEncoderParent.cpp(263): error C3861: 'Dispatch': identifier not found

We need to #include "mozilla/SystemGroup.h" in there.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1349008 - Include SystemGroup.h in GMPVideoEncoderParent to fix unified build bustage caused by bug 1346681.

Review commit: https://reviewboard.mozilla.org/r/122122/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/122122/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8849316 [details]
Bug 1349008 - Include SystemGroup.h in GMPVideoEncoderParent to fix unified build bustage caused by bug 1346681.

https://reviewboard.mozilla.org/r/122122/#review124246

LGTM.

Comment 3

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 594ddaaf76eb -d 7ba1abadab3f: rebasing 382979:594ddaaf76eb "Bug 1349008 - Include SystemGroup.h in GMPVideoEncoderParent to fix unified build bustage caused by bug 1346681. r=jwwang" (tip)
merging dom/media/gmp/GMPVideoEncoderParent.cpp
warning: conflicts while merging dom/media/gmp/GMPVideoEncoderParent.cpp! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8849316 [details]
Bug 1349008 - Include SystemGroup.h in GMPVideoEncoderParent to fix unified build bustage caused by bug 1346681.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/122122/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6982979c2042
Include SystemGroup.h in GMPVideoEncoderParent to fix unified build bustage caused by bug 1346681. r=jwwang

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6982979c2042