1349022 - Build system passes -DTRACING, which nothing cares about

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jim Blandy :jimb]

Attachment: Don't put -DTRACING in the C/C++ flags for debug builds; nobody uses it.

As far as I can tell, there is no code in Mozilla Central that checks the TRACING preprocessor symbol, so there is no need for build/autoconf/compiler-opts.m4 to pass it.

Comment 1

[Mike Hommey [:glandium]]

Comment on attachment 8849342 [details] [diff] [review]
Don't put -DTRACING in the C/C++ flags for debug builds; nobody uses it.

IIRC it's used in system headers on MSVC.

Comment 2

[Jim Blandy :jimb]

I can't find anything about this on msdn.microsoft.com. I asked my local Windows programming expert:

<jimb> mhowell: Does #defining TRACING do anything interesting with Windows system headers?
<mhowell> jimb: nothing I know of

So I think this is [citation needed].

Comment 3

[Molly Howell (she/her) (mostly inactive)]

Did some more searching and couldn't find anything mentioning a TRACING symbol. Also grepped the MSVC and Windows 8.1 SDK headers and didn't get any hits.

Plus, "TRACING" isn't nearly verbose enough to be a Microsoft symbol name. ;)

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8849342 [details] [diff] [review]
Don't put -DTRACING in the C/C++ flags for debug builds; nobody uses it.

Review of attachment 8849342 [details] [diff] [review]:
-----------------------------------------------------------------

I went ahead just checking the entire preprocessed output with and without -DTRACING, on all platforms. There's no difference, except for the buildid in nsBrowserApp.i and nsAppRunner.i (which is expected).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/80c08496fae6
Don't put -DTRACING in the C/C++ flags for debug builds since nobody uses it. r=glandium

Comment 6

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/80c08496fae6