1349124 - Rename ServoComputedStyleValues

Status: RESOLVED FIXED

(Core :: DOM: Animation, enhancement, P5)

Description

[Boris Chiou [:boris]]

According to Bug 1343753 Comment 22, we have ServoComputedValues *and* ServoComputedStyleValues, and they are not easy to be distinguished, so we should have named ServoComputedStyleValues something else like ServoComputedStylePair, ServoComputedStyleContext, ServoCurrentAndParentStyle, or something.

I prefer ServoComputedStylePair.

Comment 1

[Boris Chiou [:boris]]

Oh, but ServoComputedStyleContext might be better because we store parent and child, and this could be a counterpart of nsStyleContext for animation.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

(In reply to Boris Chiou [:boris] from comment #1)
> Oh, but ServoComputedStyleContext might be better because we store parent
> and child, and this could be a counterpart of nsStyleContext for animation.

Using 'StyleContext' for servo's value is somewhat misleading. Servo has StyleContext that is a global value during traversal.
How about ServoComputedValuesWithParent?  If it's too long, I will +1 for ServoComputedStylePair.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #2)
> (In reply to Boris Chiou [:boris] from comment #1)
> > Oh, but ServoComputedStyleContext might be better because we store parent
> > and child, and this could be a counterpart of nsStyleContext for animation.
> 
> Using 'StyleContext' for servo's value is somewhat misleading. Servo has
> StyleContext that is a global value during traversal.

Oops. Wrong. StyleContext is not global.

Comment 4

[Boris Chiou [:boris]]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #3)
> (In reply to Hiroyuki Ikezoe (:hiro) from comment #2)
> > (In reply to Boris Chiou [:boris] from comment #1)
> > > Oh, but ServoComputedStyleContext might be better because we store parent
> > > and child, and this could be a counterpart of nsStyleContext for animation.
> > 
> > Using 'StyleContext' for servo's value is somewhat misleading. Servo has
> > StyleContext that is a global value during traversal.
> 
> Oops. Wrong. StyleContext is not global.

OK, so is your preference still ServoComputedValuesWithParent? I'm ok to both names.

Comment 5

[Boris Chiou [:boris]]

Attachment: Bug 1349124 - Replace ServoComputedStyleValues with ServoComputedValuesWithParent.

Review commit: https://reviewboard.mozilla.org/r/122218/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/122218/

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8849452 [details]
Bug 1349124 - Replace ServoComputedStyleValues with ServoComputedValuesWithParent.

https://reviewboard.mozilla.org/r/122218/#review124340

Thanks!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1900c9b545a2
Replace ServoComputedStyleValues with ServoComputedValuesWithParent. r=hiro

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1900c9b545a2