1349149 - stylo: Build failure in geckoservo crate with rustc 1.16.0

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

I got the following error message when building stylo after upgrading rustc to 1.16.0.

 5:35.36    Compiling geckoservo v0.0.1 (file:///Users/tlin/Projects/gecko-dev/servo/ports/geckolib)
 5:35.99 error: unused `#[macro_use]` import
 5:35.99   --> /Users/tlin/Projects/gecko-dev/servo/ports/geckolib/lib.rs:10:1
 5:35.99    |
 5:35.99 10 | #[macro_use] extern crate lazy_static;
 5:35.99    | ^^^^^^^^^^^^
 5:35.99    |
 5:35.99 note: lint level defined here
 5:35.99   --> /Users/tlin/Projects/gecko-dev/servo/ports/geckolib/lib.rs:5:9
 5:35.99    |
 5:35.99 5  | #![deny(warnings)]
 5:35.99    |         ^^^^^^^^
 5:35.99 
 5:36.00 error: aborting due to previous error
 5:36.00 
 5:36.02 error: Could not compile `geckoservo`.

I'll upload a PR to servo/servo.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

FWIW, I have the following in my MOZCONFIG.

ac_add_options --enable-debug
ac_add_options --disable-optimize

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Pushed a try to test building without --disable-optimize

https://treeherder.mozilla.org/#/jobs?repo=try&revision=41b882866322914018b3abe921f1b0a7fb65a494

Comment 3

[Jan Beich]

Probably a recent regression. Stylo builds fine with Rust 1.16.0 before mozilla-central changeset e3e83e6bf409 or https://github.com/servo/servo/commit/1bacd0eb1582

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

This should be fixed by https://hg.mozilla.org/integration/autoland/rev/68e06a8f32fb

Comment 5

[Jan Beich]

https://hg.mozilla.org/mozilla-central/rev/68e06a8f32fb
https://hg.mozilla.org/mozilla-central/rev/a5be9ebac04f