Make nsIEditor.transactionManager readonly

RESOLVED FIXED in Firefox 55

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

Trunk
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

nsITransactionManager is a builtinclass. Therefore, JS cannot replace it with its original one. So, setting value must be another editor's transaction manager or same editor's but already initialized again.

Additionally, if transaction manager is detached from original editor, it's difficult to manager their relation especially when the editor is marked destroyed. So, it may cause memory leak if there are some circular references.
Comment hidden (mozreview-request)

Comment 4

2 years ago
mozreview-review
Comment on attachment 8849794 [details]
Bug 1349178 Make nsIEditor.transactionManager readonly

https://reviewboard.mozilla.org/r/122554/#review124740
Attachment #8849794 - Flags: review?(m_kato) → review+

Comment 5

2 years ago
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/59fa92404734
Make nsIEditor.transactionManager readonly r=m_kato

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/59fa92404734
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.