Closed Bug 1349178 Opened 4 years ago Closed 4 years ago

Make nsIEditor.transactionManager readonly

Categories

(Core :: DOM: Editor, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

nsITransactionManager is a builtinclass. Therefore, JS cannot replace it with its original one. So, setting value must be another editor's transaction manager or same editor's but already initialized again.

Additionally, if transaction manager is detached from original editor, it's difficult to manager their relation especially when the editor is marked destroyed. So, it may cause memory leak if there are some circular references.
Comment on attachment 8849794 [details]
Bug 1349178 Make nsIEditor.transactionManager readonly

https://reviewboard.mozilla.org/r/122554/#review124740
Attachment #8849794 - Flags: review?(m_kato) → review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/59fa92404734
Make nsIEditor.transactionManager readonly r=m_kato
https://hg.mozilla.org/mozilla-central/rev/59fa92404734
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.