1349178 - Make nsIEditor.transactionManager readonly

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Looks like that anybody (including comm-central and BlueGriffon) doesn't set nsIEditor.transactionManager. So, we can make it readonly attribute.

Note that replacing transaction manager may have security risk. So, there must be no reason to allow to set it.

http://searchfox.org/mozilla-central/search?q=symbol:_ZN9nsIEditor21GetTransactionManagerEPP21nsITransactionManager%2C_ZN9nsIEditor21SetTransactionManagerEP21nsITransactionManager%2C%23transactionManager&redirect=false
http://searchfox.org/comm-central/search?q=symbol:_ZN9nsIEditor21GetTransactionManagerEPP21nsITransactionManager%2C_ZN9nsIEditor21SetTransactionManagerEP21nsITransactionManager%2C%23transactionManager&redirect=false
https://github.com/therealglazou/bluegriffon/search?utf8=%E2%9C%93&q=transactionManager

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7b2afca31770

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

nsITransactionManager is a builtinclass. Therefore, JS cannot replace it with its original one. So, setting value must be another editor's transaction manager or same editor's but already initialized again.

Additionally, if transaction manager is detached from original editor, it's difficult to manager their relation especially when the editor is marked destroyed. So, it may cause memory leak if there are some circular references.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1349178 Make nsIEditor.transactionManager readonly

There are no app which replaces transaction manager of editor.  Additionally, replacing transaction manager of an editor with different editor or same editor but after initialized again due to some reasons may cause unexpected problems.

Therefore, this patch makes it readonly.

Review commit: https://reviewboard.mozilla.org/r/122554/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/122554/

Comment 4

[Makoto Kato [:m_kato]]

Comment on attachment 8849794 [details]
Bug 1349178 Make nsIEditor.transactionManager readonly

https://reviewboard.mozilla.org/r/122554/#review124740

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59fa92404734
Make nsIEditor.transactionManager readonly r=m_kato

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/59fa92404734