|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
59 bytes, text/x-review-board-request
|Details | Review|
Looks like that anybody (including comm-central and BlueGriffon) doesn't set nsIEditor.transactionManager. So, we can make it readonly attribute. Note that replacing transaction manager may have security risk. So, there must be no reason to allow to set it. http://searchfox.org/mozilla-central/search?q=symbol:_ZN9nsIEditor21GetTransactionManagerEPP21nsITransactionManager%2C_ZN9nsIEditor21SetTransactionManagerEP21nsITransactionManager%2C%23transactionManager&redirect=false http://searchfox.org/comm-central/search?q=symbol:_ZN9nsIEditor21GetTransactionManagerEPP21nsITransactionManager%2C_ZN9nsIEditor21SetTransactionManagerEP21nsITransactionManager%2C%23transactionManager&redirect=false https://github.com/therealglazou/bluegriffon/search?utf8=%E2%9C%93&q=transactionManager
nsITransactionManager is a builtinclass. Therefore, JS cannot replace it with its original one. So, setting value must be another editor's transaction manager or same editor's but already initialized again. Additionally, if transaction manager is detached from original editor, it's difficult to manager their relation especially when the editor is marked destroyed. So, it may cause memory leak if there are some circular references.
Comment on attachment 8849794 [details] Bug 1349178 Make nsIEditor.transactionManager readonly https://reviewboard.mozilla.org/r/122554/#review124740
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/59fa92404734 Make nsIEditor.transactionManager readonly r=m_kato