1349185 - AMO add-ons are not installed from bookmark sidebar

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, defect, P5)

Description

[Vasilica Tamas, QA [:vtamas]]

Attachment: Animation.gif

[Affected versions]:
Firefox 55.0a1 (2017-03-20)
Firefox 54.0a2 (2017-03-20)
Firefox 53.0b4 (20170316212821)
Firefox 52.0 (20170302120751)

[Affected platforms]:
Windows 10 64-bit
Ubuntu 16.04 32-bit

[Steps to reproduce]:
1.Launch Firefox with clean profile.
2.Navigate to https://addons.mozilla.org/en-US/firefox/ and bookmark the page.
3.Right click on bookmark and select Properties.
4.Check “Load this bookmark in the sidebar” checkbox and click “Save” button.
5.Click on bookmark in order to open it in sidebar.
6.Choose an add-on and click on “+ Add to Firefox” green button. 


[Expected Results]:
The add-ons are successfully installed from bookmarks sidebar.


[Actual Results]:
- Nothing happens while clicking on “+ Add to Firefox” button.
- There are no errors thrown in Browser Console.
- See attached screencast.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

This is only barely related to bookmarks, it's likely more related to sidebar permissions.
the only bookmark related thing is opening a url in the sidebar.
Not sure where this should go, but likely it's a P5

Comment 2

[Andrew Swan [:aswan]]

I'm not sure what's going on here, when we get into install() here, "this" doesn't appear to be set correctly:
http://searchfox.org/mozilla-central/rev/7419b368156a6efa24777b21b0e5706be89a9c2f/toolkit/mozapps/extensions/amInstallTrigger.js#160-196

Comment 3

[:Gijs (he/him)]

(In reply to Andrew Swan [:aswan] from comment #2)
> I'm not sure what's going on here, when we get into install() here, "this"
> doesn't appear to be set correctly:
> http://searchfox.org/mozilla-central/rev/
> 7419b368156a6efa24777b21b0e5706be89a9c2f/toolkit/mozapps/extensions/
> amInstallTrigger.js#160-196

What is it set to instead? I almost wonder if this is a webidl bindings bug in this case... which might be more important than the functional issue this got filed as. :S

Comment 4

[Andrew Swan [:aswan]]

(In reply to :Gijs from comment #3)
> (In reply to Andrew Swan [:aswan] from comment #2)
> > I'm not sure what's going on here, when we get into install() here, "this"
> > doesn't appear to be set correctly:
> > http://searchfox.org/mozilla-central/rev/
> > 7419b368156a6efa24777b21b0e5706be89a9c2f/toolkit/mozapps/extensions/
> > amInstallTrigger.js#160-196
> 
> What is it set to instead? I almost wonder if this is a webidl bindings bug
> in this case... which might be more important than the functional issue this
> got filed as. :S

I'm not sure what the proper term is for it but it looks like the global into which amInstallTrigger.js is loaded.  That is, it has has properties like "CallbackObject", "RemoteMediator", etc which are symbols defined in amInstallTrigger.js plus properties for various Chrome-only thing (e.g. ChromeWorker)

Comment 5

[Andrew Swan [:aswan]]

Gijs, is there anything I can do to help move this bug along?

Comment 6

[:Gijs (he/him)]

(In reply to Andrew Swan [:aswan] from comment #5)
> Gijs, is there anything I can do to help move this bug along?

I don't really know besides asking someone who knows about our webidl bindings... Maybe :peterv knows, or can redirect to someone who does? (please see comment #2 / comment #4)

Comment 7

[Peter Van der Beken [:peterv]]

That's probably the right global, the XPCOM component doesn't live in the scope of the window that it's instantiated for. See the comment at http://searchfox.org/mozilla-central/rev/7419b368156a6efa24777b21b0e5706be89a9c2f/toolkit/mozapps/extensions/amInstallTrigger.js#126 and bug 926712.

Comment 8

[Andy McKay]

Is opening a URL from a bookmark in a sidebar something we still want to support? It seems like a pretty obscure thing that we make hard to do. 

Although I will say the new mobile AMO pages do look great in the sidebar :)

Comment 9

[Kestrel]

(In reply to Andy McKay [:andym] from comment #8)
> Is opening a URL from a bookmark in a sidebar something we still want to support?

Bug 1374799 suggests so.

Comment 10

[Andrew Swan [:aswan]]

(In reply to Andy McKay [:andym] from comment #8)
> Is opening a URL from a bookmark in a sidebar something we still want to
> support? It seems like a pretty obscure thing that we make hard to do. 

I don't really have an opinion on that, but this bug suggests a possibly bigger underlying problem with sidebars.
I think comment 2 might have actually been the browser console lying to me (I've noticed it getting confused about "this" multiple times since then).  I haven't had time to follow up on either the devtools issue or this issue, but I don't think this should be closed until we get to the bottom of it.

Comment 11

[Mark Banner (:standard8)]

"Load this bookmark in the sidebar" has now been removed in bug 1452645 so this is a wontfix.