1349278 - SSL cipher enumeration

Status: RESOLVED FIXED

(JSS Graveyard :: Library, defect)

Description

[Endi S. Dewata]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20170316213829

Steps to reproduce:

Bug #118646 added SSLSocket.getImplementedCipherSuites() which returns cipher IDs. However, currently applications are still responsible for the conversion between cipher IDs and human-readable strings, causing duplicate effort and maintenance issue.

For example, see the cipherMap in the following files:
* https://github.com/dogtagpki/tomcatjss/blob/master/src/org/apache/tomcat/util/net/jss/JSSSocketFactory.java
* https://github.com/dogtagpki/tomcatjss/blob/master/src/org/apache/tomcat/util/net/jss/JSSSocketFactory.java




Expected results:

JSS should provide an enumeration class that contains all known SSL ciphers and provide a mechanism to convert between cipher ID and enumeration constant. The enumeration class itself will provide a built-in mechanism to convert between enumeration constant and human-readable string.

Comment 1

[Endi S. Dewata]

Sorry, the second example should have been:
* https://github.com/dogtagpki/pki/blob/master/base/util/src/com/netscape/cmsutil/crypto/CryptoUtil.java

Comment 2

[Endi S. Dewata]

Attachment: 0001-Added-SSLCipher-enumeration.patch

The cipher constants in SSLSocket have been copied and converted
into SSLCipher enumeration. The enumeration provides a mechanism
to convert between cipher ID and cipher constant, also a flag to
indicate whether it is an ECC cipher.

Comment 3

[Endi S. Dewata]

Attachment: 0001-Added-SSLCipher-enumeration.patch

The new patch is identical. I only added the bug URL into the patch description.

Comment 4

[Elio Maldonado]

Comment on attachment 8849655 [details] [diff] [review]
0001-Added-SSLCipher-enumeration.patch

Review of attachment 8849655 [details] [diff] [review]:
-----------------------------------------------------------------

This is a subset of what NSS has but I think that's fine. JSS does not yet support all of the NSS supported cipher suites and that's what Bug 1321594 is for.

Comment 5

[Elio Maldonado]

Pushed: https://hg.mozilla.org/projects/jss/rev/65c1bd09694b7e2a850692a39303a851a56a6f32