Open Bug 1349297 Opened 8 years ago Updated 2 years ago

stylo: Parse PropertyId from Atom in will-change to remove intermediate steps

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Tracking Flags:
Tracking Status
firefox57 --- wontfix

People

(Reporter: canova, Unassigned)

References

(Blocks 1 open bug)

Details

In the glue of the will-change property, we are currently trying to parse PropertyId with `PropertyId::parse` method. This method takes `Cow<str>` as parameter but we have a vector of atoms in the will-change property. Therefore we are trying to allocate and move the value for this method. Probably we need a parse method that takes an Atom instead.
Also we should serialize identifiers without converting an intermediate String. See the discussion at https://github.com/servo/servo/pull/15813
Well, I filed it to Servo side(https://github.com/servo/servo/issues/16065) because I thought it's more related to cssparser but yeah, also that.
Priority: -- → P4
Summary: Stylo: Parse PropertyId from Atom in will-change to remove intermediate steps → stylo: Parse PropertyId from Atom in will-change to remove intermediate steps
status-firefox57=wontfix unless someone thinks this bug should block 57
status-firefox57: --- → wontfix
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.