1349338 - MOZ_SAFEBROWSING_DUMP_FAILED_UPDATES should be defined in debug builds

Status: RESOLVED WORKSFORME

(Toolkit :: Safe Browsing, enhancement, P3)

Description

[François Marier [:francois]]

Right now, the failed update dumping code is never compiled in because it sits behind a compile-time option: MOZ_SAFEBROWSING_DUMP_FAILED_UPDATES.

We should enable this code in debug builds so that it gets exercised a little bit (at the very least we'll know it still compiles) and that it's easy for anybody with a debug build to send us a copy of their state.

Do you agree Henry?

Comment 1

[Henry Chang [:hchang]]

As far as I can tell, it's still being compiled on every debug build on try and Nightly.

I am quite certain it will be compiled on try debug build because I did see some crash log
on try when my patch for Bug 1339050 was still broken. (has been fixed already though :))

http://searchfox.org/mozilla-central/rev/0079c7adf3b329bff579d3bbe6ac7ba2f6218a19/toolkit/components/url-classifier/moz.build#85

Comment 2

[François Marier [:francois]]

(In reply to Henry Chang [:henry][:hchang] from comment #1)
> As far as I can tell, it's still being compiled on every debug build on try
> and Nightly.
> 
> I am quite certain it will be compiled on try debug build because I did see
> some crash log
> on try when my patch for Bug 1339050 was still broken. (has been fixed
> already though :))
> 
> http://searchfox.org/mozilla-central/rev/
> 0079c7adf3b329bff579d3bbe6ac7ba2f6218a19/toolkit/components/url-classifier/
> moz.build#85

It's hard to argue with this :)

I'm glad you thought about that already when it landed!