Closed Bug 1349434 Opened 5 years ago Closed 5 years ago
Save of JSON from JSONviewer doesn't work/save file to location/folder/directory
Nightly on OSX. Tried to save a JSON file (700kb) using the Save button. No file appeared in the target folder. Could not find any related error on the Browser Toolbox.
[Tracking Requested - why for this release]: Broken feature exposed by UI (brokenness might be noticed with delay). This is a regression from bug 1334975 / https://hg.mozilla.org/mozilla-central/rev/5ed300efb2fa#l5.1 baku, can you take a look at this, please?
Summary: Save doesn't work → Save of JSON from JSONviewer doesn't work/save file to location/folder/directory
Assignee: nobody → amarchesini
Attachment #8849990 - Flags: review?(kyle) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5a49f28a2a6a Fixing the saving in the JSONviewer, r=qdot
Please request aurora uplift when you get a chance. (Also kind of surprised this isn't covered by automated tests?)
Comment on attachment 8849990 [details] [diff] [review] jsonview.patch Approval Request Comment [Feature/Bug causing the regression]: Bu1334975 [User impact if declined]: JSONView save feature is broken [Is this code covered by automated tests?]: none [Has the fix been verified in Nightly?]: yes [Needs manual test from QE? If yes, steps to reproduce]: yes. Just try to save a JSON from the JSONView. [List of other uplifts needed for the feature/fix]: none [Is the change risky?]: no. [Why is the change risky/not risky?]: I just forgot a 'then' in the previous patch. [String changes made/needed]: none
Attachment #8849990 - Flags: approval-mozilla-aurora?
Hi :Harald, could you help check if this issue was fixed as expected on a latest Nightly build? Thanks!
Comment on attachment 8849990 [details] [diff] [review] jsonview.patch Confirmed working for me in today's nightly, broken in aurora, let's uplift this.
Attachment #8849990 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
I managed to reproduce the bug on Nightly from 2017-03-21. Then I tested using this JsonView (https://jsonview.com/example.json) and the files were successfully saved. I used the latest Nightly and Firefox 55.0b13 on Windows 10 x64, Ubuntu 16.04 x64 and on Mac OS x 10.11 and the issue seems to be fixed.
You need to log in before you can comment on or make changes to this bug.