1349459 - Mark a video element as taint and never suspend it again if it is passed into createImageBitmap()

Status: VERIFIED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Tzuhao Kuo [:kaku]]

Similar to bug 1345403 and bug 1349456.

Comment 1

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1349459 part 1 - mark element as tainted when CreateImageBitmap() is used;

In this patch, we simply modify the ImageBitmap::createInternal(..., HTMLMediaElement&, ...) method to use
HTMLMediaElement::GetCurrentImage() utility and HTMLMediaElement::GetCurrentImage() marks the
videl element as tainted.

Review commit: https://reviewboard.mozilla.org/r/122612/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/122612/

Comment 2

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1349459 part 2 - test element as tainted when CreateImageBitmap() is used;

Review commit: https://reviewboard.mozilla.org/r/122614/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/122614/

Comment 3

[Tzuhao Kuo [:kaku]]

Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0fafe7ca1f6b62b9522ab571a7b3dd09c8d3a201
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a169f992f6395b6d746411d2e5f2fa8ad85063c

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8849893 [details]
Bug 1349459 part 2 - test element as tainted when CreateImageBitmap() is used;

https://reviewboard.mozilla.org/r/122614/#review124808

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8849892 [details]
Bug 1349459 part 1 - mark element as tainted when CreateImageBitmap() is used;

https://reviewboard.mozilla.org/r/122612/#review124810

Comment 6

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8849892 [details]
Bug 1349459 part 1 - mark element as tainted when CreateImageBitmap() is used;

https://reviewboard.mozilla.org/r/122612/#review124822

Comment 7

[Tzuhao Kuo [:kaku]]

Try looks good, thanks for the review!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f64ffac91054
part 1 - mark element as tainted when CreateImageBitmap() is used; r=jwwang,mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/4a8979c4c9df
part 2 - test element as tainted when CreateImageBitmap() is used; r=jwwang

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f64ffac91054
https://hg.mozilla.org/mozilla-central/rev/4a8979c4c9df

Comment 10

[Adrian Florinescu [:aflorinescu]]

Verified as fixed across Ubuntu 16.04, Mac OSX 10.10, Windows10.