_beginRemoveTab should skip the whole permitUnload block for tabs that don't have content attached

RESOLVED FIXED in Firefox 55

Status

()

Firefox
Tabbed Browser
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: dao, Assigned: dao)

Tracking

unspecified
Firefox 55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

11 months ago
missed this in my review for bug 1342723
Comment hidden (mozreview-request)
(Assignee)

Updated

11 months ago
Attachment #8849938 - Flags: review?(kevinhowjones)

Updated

11 months ago
Attachment #8849938 - Flags: review?(kevinhowjones) → review+

Comment 3

11 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1cd8cb801e29
Let _beginRemoveTab skip the whole permitUnload block for tabs that don't have content attached. r=kevinhowjones

Comment 4

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1cd8cb801e29
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.