1349502 - tabbrowser.xml should use AppConstants from the global scope

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement)

Description

[Dão Gottwald [:dao]]

Instead of 'this.AppConstants' and 'this.tabbrowser.AppConstants', tabbrowser.xml should use the global 'AppConstants', and we should remove this field:

http://searchfox.org/mozilla-central/rev/0079c7adf3b329bff579d3bbe6ac7ba2f6218a19/browser/base/content/tabbrowser.xml#71-73

Comment 1

[Ganesh Chaitanya Kale]

Hey Dao,

I would like to work on this bug. Please let me know on how to proceed on this.

Regards,
Ganesh

Comment 2

[Dão Gottwald [:dao]]

(In reply to ganesh2583 from comment #1)
> Hey Dao,
> 
> I would like to work on this bug. Please let me know on how to proceed on
> this.

The basic instructions are in the first comment. Is something unclear there?

Comment 3

[Ganesh Chaitanya Kale]

I understood the change that needs to be done. We have to remove the references in lines 71-73 and change the concurrences of this.AppConstants and this.tabbrowser.AppConstants to AppConstants. Let me know if its correct.

Comment 4

[Dão Gottwald [:dao]]

That's correct.

Comment 5

[Ganesh Chaitanya Kale]

Attachment: Create the patch with the fix.

I have attached the patch. Please review and let me know if any further changes are required.

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 8850051 [details] [diff] [review]
Create the patch with the fix.

Looks good!

Try run to see if this causes test failures: https://treeherder.mozilla.org/#/jobs?repo=try&revision=414c6ec60efc1ba057ffe461b7d0cd0f61d3c3ff

Comment 7

[Ganesh Chaitanya Kale]

(In reply to Dão Gottwald [::dao] from comment #6)
> Comment on attachment 8850051 [details] [diff] [review]
> Create the patch with the fix.
> 
> Looks good!
> 
> Try run to see if this causes test failures:
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=414c6ec60efc1ba057ffe461b7d0cd0f61d3c3ff

Hey DAO,

How can I run the tests, can you please let me know. I did a mach run and the Nightly Build Mozilla is up and I opened the link you have provided. If not sure on how to go forward after that.

Regards,
Ganesh

Comment 8

[Dão Gottwald [:dao]]

The tests run automatically on the Try server. The test results appear under the link I posted as the tests finish.

Comment 9

[Ganesh Chaitanya Kale]

I executed the command ./mach mochitest -f browser and tests are running locally.

Comment 10

[Ganesh Chaitanya Kale]

I think there are no failures seeing the below link:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=414c6ec60efc1ba057ffe461b7d0cd0f61d3c3ff&filter-resultStatus=runnable&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=success

Comment 11

[Dão Gottwald [:dao]]

Yep, looks good.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d61e2f8bf8f7
Make tabbrowser.xml use AppConstants from the global scope. r=dao

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d61e2f8bf8f7