Closed Bug 1349502 Opened 5 years ago Closed 5 years ago

tabbrowser.xml should use AppConstants from the global scope

Categories

(Firefox :: Tabbed Browser, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: dao, Assigned: ganesh2583, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [good first bug][lang=js])

Attachments

(1 file)

Instead of 'this.AppConstants' and 'this.tabbrowser.AppConstants', tabbrowser.xml should use the global 'AppConstants', and we should remove this field:

http://searchfox.org/mozilla-central/rev/0079c7adf3b329bff579d3bbe6ac7ba2f6218a19/browser/base/content/tabbrowser.xml#71-73
Hey Dao,

I would like to work on this bug. Please let me know on how to proceed on this.

Regards,
Ganesh
(In reply to ganesh2583 from comment #1)
> Hey Dao,
> 
> I would like to work on this bug. Please let me know on how to proceed on
> this.

The basic instructions are in the first comment. Is something unclear there?
I understood the change that needs to be done. We have to remove the references in lines 71-73 and change the concurrences of this.AppConstants and this.tabbrowser.AppConstants to AppConstants. Let me know if its correct.
That's correct.
I have attached the patch. Please review and let me know if any further changes are required.
Attachment #8850051 - Flags: review?(dao+bmo)
Comment on attachment 8850051 [details] [diff] [review]
Create the patch with the fix.

Looks good!

Try run to see if this causes test failures: https://treeherder.mozilla.org/#/jobs?repo=try&revision=414c6ec60efc1ba057ffe461b7d0cd0f61d3c3ff
Attachment #8850051 - Flags: review?(dao+bmo) → review+
Assignee: nobody → ganesh2583
(In reply to Dão Gottwald [::dao] from comment #6)
> Comment on attachment 8850051 [details] [diff] [review]
> Create the patch with the fix.
> 
> Looks good!
> 
> Try run to see if this causes test failures:
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=414c6ec60efc1ba057ffe461b7d0cd0f61d3c3ff

Hey DAO,

How can I run the tests, can you please let me know. I did a mach run and the Nightly Build Mozilla is up and I opened the link you have provided. If not sure on how to go forward after that.

Regards,
Ganesh
The tests run automatically on the Try server. The test results appear under the link I posted as the tests finish.
I executed the command ./mach mochitest -f browser and tests are running locally.
Yep, looks good.
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d61e2f8bf8f7
Make tabbrowser.xml use AppConstants from the global scope. r=dao
https://hg.mozilla.org/mozilla-central/rev/d61e2f8bf8f7
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.