Closed
Bug 1349513
Opened 8 years ago
Closed 8 years ago
Move tests related to web permissions from test/general to test/permissions
Categories
(Firefox :: Site Identity, enhancement, P1)
Firefox
Site Identity
Tracking
()
RESOLVED
FIXED
Firefox 55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: johannh, Assigned: johannh)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxprivacy])
Attachments
(1 file)
This would include the 3 test files for temporary permissions and more files that are related to web permissions (e.g. the one we should add to test bug 1348257).
|
Assignee | |
Comment 1•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ffb238df098d3b204a06d14980cfa7c6b78ce63
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 3•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=78b5d947e0e62552c0a3a1b850ee2040da2e320d
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 5•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c3e5067e36f5919a52e00f84a50cec98a416d52f
| Comment hidden (mozreview-request) |
|
||
Comment 7•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8850556 [details] Bug 1349513 - Move tests related to web permissions from test/general to test/permissions. https://reviewboard.mozilla.org/r/123120/#review125908 ::: browser/base/content/test/permissions/head.js:15 (Diff revision 3) > + * The url to load, or the current url. > + * @return {Promise} resolved when the event is handled. > + * @resolves to the received event > + * @rejects if a valid load event is not received within a meaningful interval > + */ > +function promiseTabLoadEvent(tab, url) { There's only 1 test that uses this. Can just move it in there and/or replace with `browserLoaded` usage directly?
Attachment #8850556 -
Flags: review?(gijskruitbosch+bugs) → review+
| Comment hidden (mozreview-request) |
Pushed by jhofmann@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/60723775132c Move tests related to web permissions from test/general to test/permissions. r=Gijs
|
||
Comment 10•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/60723775132c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in
before you can comment on or make changes to this bug.
Description
•