Thunderbird 52.0 build4: failed at thunderbird_release_updates

RESOLVED FIXED

Status

enhancement
P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: wsmwk, Assigned: Fallen)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
per rail...

This** is because 45.8.0 was listed in partials but it is not in https://hg.mozilla.org/build/tools/file/tip/release/patcher-configs/mozEsr52-thunderbird-branch-patcher2.cfg.

To fix the issue we need to:
1) add <45.8.0> release entry to the config above (the following hunk: https://hg.mozilla.org/build/tools/rev/b95282e941f7#l1.96)
2) add the "post-update" change from the same commit: https://hg.mozilla.org/build/tools/rev/b95282e941f7#l1.78
3) retag the changes and rerun the step


** https://archive.mozilla.org/pub/thunderbird/candidates/52.0-candidates/build4/logs/release-comm-esr52-thunderbird_release_updates-bm74-build1-build0.txt.gz

Traceback (most recent call last):
  File "tools/scripts/updates/create-update-verify-configs.py", line 106, in <module>
    pc = PatcherConfig(open(options.config).read())
  File "/builds/slave/tb-rel-c-esr52-tb_rel_upds-000/tools/lib/python/release/updates/patcher.py", line 44, in __init__
    self.readXml(cfg)
  File "/builds/slave/tb-rel-c-esr52-tb_rel_upds-000/tools/lib/python/release/updates/patcher.py", line 228, in readXml
    self['current-update']['from'])
release.updates.patcher.PatcherConfigError: No release found for version '45.8.0'
State Changed: unlock buildroot
program finished with exit code 1
elapsedTime=21.109042

Updated

2 years ago
Priority: -- → P2
(Assignee)

Comment 1

2 years ago
Posted patch Fix - v1Splinter Review
So per those steps this should be the right thing to do. Just to confirm, I would be retagging THUNDERBIRD_52_0_RELEASE and THUNDERBIRD_52_0_BUILD4, right?
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #8851220 - Flags: review?(rail)

Updated

2 years ago
Attachment #8851220 - Flags: review?(rail) → review+
(In reply to Philipp Kewisch [:Fallen] from comment #1)
> Created attachment 8851220 [details] [diff] [review]
> Fix - v1
> 
> So per those steps this should be the right thing to do. Just to confirm, I
> would be retagging THUNDERBIRD_52_0_RELEASE and THUNDERBIRD_52_0_BUILD4,
> right?

Correct
(Assignee)

Comment 3

2 years ago
https://hg.mozilla.org/build/tools/rev/b8a27ca91fa4337f25278d27d16567a4ace6f82f
https://hg.mozilla.org/build/tools/rev/fe455a362a6755d3a37e402408eb6800601491ac

rail, can you rerun the build step?
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Flags: needinfo?(rail)
Resolution: --- → FIXED
It's pending now.
Flags: needinfo?(rail)
You need to log in before you can comment on or make changes to this bug.