1349533 - Add a delete storage button in the toolbar

Status: RESOLVED FIXED

(DevTools :: Storage Inspector, enhancement, P3)

Description

[Patrick Brosset <:pbro>]

You can already delete storage types by right-clicking in the sidebar, but anything hidden in a context menu has a tendency of not being used much.

I wonder if we couldn't add a button in the toolbar of the storage inspector that does the same thing.
Obviously we would also keep the context menu, this would just be an additional way of doing the same thing.

We have a toolbar already, with a search field. It would be a convenient place for adding this button. I suspect we will want to also add a "create" button in there eventually too, so it makes sense to have a delete button too.
Maybe 2 delete buttons: one to delete the selected row, and one to delete all?

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

We are adding a plus button to add e.g. cookies so it would make sense to add a minus button too.

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Filter on HOTFROG.

Comment 3

[Sebastian Zartner [:sebo]]

Attachment: Bug 1349533 - [devtools] Added button to delete all data of a storage. r=#devtools-reviewers

Comment 4

[Sebastian Zartner [:sebo]]

Attachment: Bug 1349533 - [devtools] Added test for button clearing all data of a storage. r=#devtools-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bacb1360060f
https://hg.mozilla.org/integration/autoland/rev/26119da52f7b
[devtools] Added button to delete all data of a storage. r=devtools-reviewers,fluent-reviewers,flod,bomsy
https://github.com/mozilla-firefox/firefox/commit/cdc8d3785480
https://hg.mozilla.org/integration/autoland/rev/7a8dfc790b36
[devtools] Added test for button clearing all data of a storage. r=devtools-reviewers,bomsy
https://github.com/mozilla-firefox/firefox/commit/ba99231d6ccf
https://hg.mozilla.org/integration/autoland/rev/0003ea8d0fd8
apply code formatting via Lando

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/213630e5786b
https://hg.mozilla.org/integration/autoland/rev/ea48e56fdd5c
Revert "Bug 1349533: apply code formatting via Lando" for causing eslint failures in browser_storage_delete_all_button.js.

Comment 7

[Serban Stanca [:SerbanS]]

Reverted this because it was causing eslint failures in browser_storage_delete_all_button.js.

• Revert link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/client/storage/test/browser_storage_delete_all_button.js:16:19 | Do not use insecure URLs (@microsoft/sdl/no-insecure-url)

Comment 8

[Serban Stanca [:SerbanS]]

.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4e1bfe598590
https://hg.mozilla.org/integration/autoland/rev/cc63aec54b20
[devtools] Added button to delete all data of a storage. r=devtools-reviewers,fluent-reviewers,flod,bomsy
https://github.com/mozilla-firefox/firefox/commit/fcf4805f1938
https://hg.mozilla.org/integration/autoland/rev/da5249f1c62c
[devtools] Added test for button clearing all data of a storage. r=devtools-reviewers,bomsy

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/cc63aec54b20
https://hg.mozilla.org/mozilla-central/rev/da5249f1c62c

Comment 11

[Pascal Chevrel:pascalc]

Is that something that should be mentioned in our 149 release notes?

Comment 12

[Sebastian Zartner [:sebo]]

I'd say yes.

Release Note Request (optional, but appreciated)
[Why is this notable]: New DevTools feature
[Affects Firefox for Android]: no
[Suggested wording]: The toolbar of the Storage Inspector now has a button to delete all entries of the currently selected storage.
[Links (documentation, blog post, etc)]:
I'll try to update https://firefox-source-docs.mozilla.org/devtools-user/storage_inspector/index.html for that, though that will probably take a bit.

Sebastian

Comment 13

[Pascal Chevrel:pascalc]

Added the release note without a link, we can add one when the documentation is updated.

I am keeping the relnote-firefox? flag set until we include this note in our final 149 release notes, thanks.