1349553 - stylo: Fix a few dynamic state change handling bugs.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P1)

Description

[Emilio Cobos Álvarez (:emilio)]

I was looking at re-enabling the tests skipped at https://hg.mozilla.org/integration/autoland/rev/ee95a66bea56e9b7044abab6f12b12257cb6b4b0 after my flag fixes, when I saw that only one of them passed.

Here's the fix for the rest of them.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=33c16a892b9b55316e47ddd4a122ff7f0fe072f3

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1349553: Add a bit of debugging information to the preprocess_children stage.

Review commit: https://reviewboard.mozilla.org/r/122766/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/122766/

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1349553: Account for negations of state-dependent selectors.

Review commit: https://reviewboard.mozilla.org/r/122768/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/122768/

Comment 4

[Bobby Holley (:bholley)]

Comment on attachment 8850015 [details]
Bug 1349553: Add a bit of debugging information to the preprocess_children stage.

https://reviewboard.mozilla.org/r/122766/#review125004

Can you make these trace!() please? I've set the logging up in traversal.rs so that we can do RUST_LOG=style/traversal.rs=debug as a first step and get nice concise output of what gets visited during the traversal (one line of logging per visited element, in general). The information in this patch is useful, but too verbose to be shown by default in a "what's going with this testcase" scenario.

r=me with that.

Comment 5

[Bobby Holley (:bholley)]

Comment on attachment 8850015 [details]
Bug 1349553: Add a bit of debugging information to the preprocess_children stage.

Second patch looks fine, but probably good for heycam to look since he has a much deeper history with these optimizations than I do.

Comment 6

[Cameron McCormack (:heycam)]

Comment on attachment 8850016 [details]
Bug 1349553: Account for negations of state-dependent selectors.

https://reviewboard.mozilla.org/r/122768/#review125248

Comment 7

[Bobby Holley (:bholley)]

https://hg.mozilla.org/integration/autoland/rev/e0546fc74c52c8b708e9e5b1a238bba0a1b241e6