Closed Bug 1349553 Opened 3 years ago Closed 3 years ago

stylo: Fix a few dynamic state change handling bugs.

Categories

(Core :: CSS Parsing and Computation, defect, P1)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(2 files)

I was looking at re-enabling the tests skipped at https://hg.mozilla.org/integration/autoland/rev/ee95a66bea56e9b7044abab6f12b12257cb6b4b0 after my flag fixes, when I saw that only one of them passed.

Here's the fix for the rest of them.
Comment on attachment 8850015 [details]
Bug 1349553: Add a bit of debugging information to the preprocess_children stage.

https://reviewboard.mozilla.org/r/122766/#review125004

Can you make these trace!() please? I've set the logging up in traversal.rs so that we can do RUST_LOG=style/traversal.rs=debug as a first step and get nice concise output of what gets visited during the traversal (one line of logging per visited element, in general). The information in this patch is useful, but too verbose to be shown by default in a "what's going with this testcase" scenario.

r=me with that.
Attachment #8850015 - Flags: review+
Comment on attachment 8850015 [details]
Bug 1349553: Add a bit of debugging information to the preprocess_children stage.

Second patch looks fine, but probably good for heycam to look since he has a much deeper history with these optimizations than I do.
Attachment #8850015 - Flags: review?(cam)
Priority: -- → P1
Comment on attachment 8850016 [details]
Bug 1349553: Account for negations of state-dependent selectors.

https://reviewboard.mozilla.org/r/122768/#review125248
Attachment #8850016 - Flags: review?(cam) → review+
https://hg.mozilla.org/integration/autoland/rev/e0546fc74c52c8b708e9e5b1a238bba0a1b241e6
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.