1349607 - Vsync marker duplicates time

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement, P2)

Description

[:Harald Kirschner :digitarald]

time and vsync are set from the same value: http://searchfox.org/mozilla-central/source/tools/profiler/core/ProfilerMarkers.cpp#230

{ name: 'VsyncTimestamp',
  time: 470067.755916,
  vsync: 470067.755916,
  category: 'VsyncTimestamp' }

category could be also dropped.

Comment 1

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1349607 - Remove mVsyncTimestamp from the VsyncMarkerPayload r?mstange

Removing this field since we already have start/end time for each marker payloads.
Also we are assigning the same timestamp to them. We don't need to unnecessarily
duplicate the information here.

Comment 2

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

See the perf.html side for that patch here: https://github.com/devtools-html/perf.html/pull/1358

Comment 3

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

(`category` field was already dropped btw.)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77b6b02860b6
Remove mVsyncTimestamp from the VsyncMarkerPayload r=mstange

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/77b6b02860b6