1349617 - Autoclassification: Always show the full error message/line, don't omit essential information/parts

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&fromchange=619b5b27ce873a7966c1198a7bf2393198653585&filter-searchStr=6d12edc1780bd31f93e2c9c0be16a35ef9337e6a&tochange=619b5b27ce873a7966c1198a7bf2393198653585

The first error gets displayed as
> GECKO(1670) | TEST-UNEXPECTED-FAIL | /tests/dom/events/test/pointerevents/pointerevent_touch-action-table-test_touch-manual.html
in the autoclassification UI.

But the log contains
> GECKO(1670) | TEST-UNEXPECTED-FAIL | /tests/dom/events/test/pointerevents/pointerevent_touch-action-table-test_touch-manual.html | touch-action attribute test on the cell: assert_true: scroll received while shouldn't expected true got false

Comment 1

[James Graham [:jgraham]]

This is really a bug in the code that gets the bug search string I think. Because there's an extra | here the normal processing breaks. I can update the backend code.

Comment 2

[GitHub Autolander Bot]

Attachment: [treeherder] mozilla:process_output > mozilla:master

Comment 3

[James Graham [:jgraham]]

Comment on attachment 8850526 [details] [review]
[treeherder] mozilla:process_output > mozilla:master

I'm not certain that this fixes the entire bug (I couldn't load the taskcluster job to check), but it fixes *a* bug.

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/ac04d5ab8c314d046016b501720d1be564b62568
Bug 1349617 - Handle process output lines in the log parser.

Process output lines start with a prefix like GECKO(1234) or PID 1234
and then a pipe. This is an extra pipe symbol compared to other lines,
so our code that splits on | and assumes specific data in specific
positions is broken. Try to detect the process output case and discard
the first token so that we have the same fields as other
pipe-delimited data.