134962 - REMINDER: check talkbacks and remove temporary code added for bug 118014

Status: RESOLVED FIXED

(Core :: Layout, defect, P1)

Description

[Marc Attinasi]

This code needs to be removed once it is no longer needed to analyze the bug
reported in bug 118014:

          // DIAGNOSTIC CHECK: bug 118014 tracks a topcrash coming out of this
call. The following
          // code to discriminate beween HTML and non HTML is an attempt to
better understand
          // what kind of element is causing the crash, since it cannot so far
be reproduced in a
          // debugging environment. (temporary: 04.02.2002 [e-mail])
          nsIContent *theContent = undisplayed->mContent;
          if (theContent->IsContentOfType(nsIContent::eHTML)) {
            // HTML element
            aPresContext->ResolveStyleContextFor(theContent, newContext, 
                                                &undisplayedContext);
          } else {
            // non-HTML element (probably XUL)
            aPresContext->ResolveStyleContextFor(theContent, newContext, 
                                                 &undisplayedContext);
          }

Comment 1

[Marc Attinasi]

accepting, and putting artificially high priority to keep it on my radar

Comment 2

[Christine Hoffman]

Changing QA contact

Comment 3

[Gavin Sinclair]

Mozilla still crashes when moving to next unread folder (if inbox is empty and
there are messages in a subfolder). Reported in bug 130720.

This was duplicate of 118014, but I still see the crash on a brand new install
of nightly 2002040403 on Windows ME. Talkback TB4821985G.

Comment 4

[Marc Attinasi]

The remp code will be removed as part of the checkin for bug 118014 - if that
ever gets approved. If not, I will remove it seperately.

Comment 5

[Marc Attinasi]

Attachment: PATCH to backout the temp code

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 78934 [details] [diff] [review]
PATCH to backout the temp code

r=dbaron

Comment 7

[Chris Waterson]

Comment on attachment 78934 [details] [diff] [review]
PATCH to backout the temp code

sr=waterson

Comment 8

[Marc Attinasi]

Backed out the code on the trunk: 
/cvsroot/mozilla/layout/html/base/src/nsFrameManager.cpp,v  <--  nsFrameManager.cpp
new revision: 1.116; previous revision: 1.115