Closed Bug 1349717 Opened 3 years ago Closed 3 years ago

Propagate errors from matching in XSLT

Categories

(Core :: XSLT, defect, critical)

x86_64
Linux
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox-esr45 --- wontfix
firefox52 --- wontfix
firefox-esr52 --- wontfix
firefox53 --- wontfix
firefox54 --- wontfix
firefox55 + fixed

People

(Reporter: peterv, Assigned: peterv)

References

Details

(4 keywords, Whiteboard: [adv-main55-][post-critsmash-triage])

Attachments

(1 file)

This is the architectural fix for bug 1336828, bug 1336832 and bug 1338277.
Attached patch v2Splinter Review
This is essentially attachment 8843257 [details] [diff] [review], which got reviewed in bug 1336828. It got backed out after landing though, so need to figure out compile errors before landing again.
Attachment #8850183 - Flags: review+
We're planning to let this ride the trains, right?
Flags: needinfo?(peterv)
(In reply to Ryan VanderMeulen [:RyanVM] from comment #2)
> We're planning to let this ride the trains, right?

Yes.
Flags: needinfo?(peterv)
https://hg.mozilla.org/mozilla-central/rev/5fa5043019f2
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Group: dom-core-security → core-security-release
(In reply to Peter Van der Beken [:peterv] from comment #1)
> Created attachment 8850183 [details] [diff] [review]
> v2
> 
> This is essentially attachment 8843257 [details] [diff] [review], which got
> reviewed in bug 1336828. It got backed out after landing though, so need to
> figure out compile errors before landing again.

Bug 1336828 was also taken in ESR52. Shouldn't this fix be taken in ESR52 as well?
Flags: needinfo?(peterv)
(In reply to Al Billings [:abillings] from comment #8)
> Bug 1336828 was also taken in ESR52. Shouldn't this fix be taken in ESR52 as
> well?

I'd rather not, I made spot fixes specifically to avoid porting the riskier change to branches.
Flags: needinfo?(peterv)
Whiteboard: [adv-main55-]
Flags: qe-verify-
Whiteboard: [adv-main55-] → [adv-main55-][post-critsmash-triage]
Group: core-security-release
You need to log in before you can comment on or make changes to this bug.