1349717 - Propagate errors from matching in XSLT

Status: RESOLVED FIXED

(Core :: XSLT, defect)

Description

[Peter Van der Beken [:peterv]]

This is the architectural fix for bug 1336828, bug 1336832 and bug 1338277.

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: v2

This is essentially attachment 8843257 [details] [diff] [review], which got reviewed in bug 1336828. It got backed out after landing though, so need to figure out compile errors before landing again.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

We're planning to let this ride the trains, right?

Comment 3

[Peter Van der Beken [:peterv]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b5b8fb0b22cd

Comment 4

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5fa5043019f2d4c9cc871ec75f0598e07f2eed22
Bug 1349717 - Propagate errors from matching in XSLT. r=erahm.

Comment 5

[Peter Van der Beken [:peterv]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #2)
> We're planning to let this ride the trains, right?

Yes.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]:

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5fa5043019f2

Comment 8

[Al Billings [:abillings - ex-MoCo]]

(In reply to Peter Van der Beken [:peterv] from comment #1)
> Created attachment 8850183 [details] [diff] [review]
> v2
> 
> This is essentially attachment 8843257 [details] [diff] [review], which got
> reviewed in bug 1336828. It got backed out after landing though, so need to
> figure out compile errors before landing again.

Bug 1336828 was also taken in ESR52. Shouldn't this fix be taken in ESR52 as well?

Comment 9

[Peter Van der Beken [:peterv]]

(In reply to Al Billings [:abillings] from comment #8)
> Bug 1336828 was also taken in ESR52. Shouldn't this fix be taken in ESR52 as
> well?

I'd rather not, I made spot fixes specifically to avoid porting the riskier change to branches.