Closed Bug 1349761 Opened 3 years ago Closed 3 years ago

Some code from browser-ctrlTab.js is showing up in profiles of opening browser windows

Categories

(Firefox :: Tabbed Browser, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 55
Iteration:
55.2 - Apr 3
Tracking Status
firefox55 --- fixed

People

(Reporter: florian, Assigned: florian)

References

(Blocks 1 open bug)

Details

(Whiteboard: [photon-performance])

Attachments

(1 file)

Even when the feature is disabled, ctrlTab.readPref is called, and calls uninit() which calls _init(false).

I saw this showing up in a profile of restoring a session with 15 empty windows, and it was taking about 0.3% of the time. So the actual performance impact isn't really significant, but after reading the code out of curiosity I was tempted to clean this up, along with a few other code cleanups in the same file.
Attached patch PatchSplinter Review
Attachment #8850227 - Flags: review?(dao+bmo)
Assignee: nobody → florian
Status: NEW → ASSIGNED
Attachment #8850227 - Flags: review?(dao+bmo) → review+
Pushed by florian@queze.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb6c2e991584
uninitialize ctrlTab only if it has been initialized before, r=dao.
https://hg.mozilla.org/mozilla-central/rev/bb6c2e991584
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Whiteboard: [photon]
Iteration: --- → 55.2 - Apr 3
Priority: -- → P1
Whiteboard: [photon] → [photon-performance]
Flags: qe-verify?
Flags: qe-verify? → qe-verify-
No longer blocks: photon-performance-triage
You need to log in before you can comment on or make changes to this bug.