Some code from browser-ctrlTab.js is showing up in profiles of opening browser windows

RESOLVED FIXED in Firefox 55

Status

()

Firefox
Tabbed Browser
P1
normal
RESOLVED FIXED
5 months ago
3 months ago

People

(Reporter: florian, Assigned: florian)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 55
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [photon-performance])

Attachments

(1 attachment)

(Assignee)

Description

5 months ago
Even when the feature is disabled, ctrlTab.readPref is called, and calls uninit() which calls _init(false).

I saw this showing up in a profile of restoring a session with 15 empty windows, and it was taking about 0.3% of the time. So the actual performance impact isn't really significant, but after reading the code out of curiosity I was tempted to clean this up, along with a few other code cleanups in the same file.
(Assignee)

Comment 1

5 months ago
Created attachment 8850227 [details] [diff] [review]
Patch
Attachment #8850227 - Flags: review?(dao+bmo)
(Assignee)

Updated

5 months ago
Assignee: nobody → florian
Status: NEW → ASSIGNED

Updated

5 months ago
Attachment #8850227 - Flags: review?(dao+bmo) → review+

Comment 2

5 months ago
Pushed by florian@queze.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb6c2e991584
uninitialize ctrlTab only if it has been initialized before, r=dao.

Comment 3

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bb6c2e991584
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
(Assignee)

Updated

5 months ago
Blocks: 1348289
Whiteboard: [photon]

Updated

4 months ago
Iteration: --- → 55.2 - Apr 3
Priority: -- → P1
Whiteboard: [photon] → [photon-performance]

Updated

4 months ago
Flags: qe-verify?

Updated

4 months ago
Flags: qe-verify? → qe-verify-
(Assignee)

Updated

3 months ago
No longer blocks: 1348289
(Assignee)

Updated

3 months ago
Blocks: 1348289
You need to log in before you can comment on or make changes to this bug.