Closed Bug 1349815 Opened 3 years ago Closed 3 years ago

stylo: Gecko_GetLookAndFeelSystemColor mutates static data

Categories

(Core :: CSS Parsing and Computation, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: bholley, Assigned: bholley)

References

Details

Attachments

(1 file, 2 obsolete files)

MozReview-Commit-ID: Auw2Kw2gBlE
Attachment #8850269 - Flags: review?(masayuki)
MozReview-Commit-ID: E9XC4kaCVd2
Attachment #8850270 - Flags: review?(masayuki)
Comment on attachment 8850269 [details] [diff] [review]
Part 1 - Explicitly initialize the LookAndFeel machinery. v1

Ugh, this turned to be a PITA. LayoutStatics is too late, since this stuff gets used during XRE init. However, doing it in XPCOM init runs afoul of content pref whitelist.

I'm just going to throw in the towel on this one.
Attachment #8850269 - Attachment is obsolete: true
Attachment #8850269 - Flags: review?(masayuki)
MozReview-Commit-ID: E9XC4kaCVd2
Attachment #8850282 - Flags: review?(cam)
Attachment #8850270 - Attachment is obsolete: true
Attachment #8850270 - Flags: review?(masayuki)
Attachment #8850282 - Flags: review?(cam) → review+
Pushed by bholley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/45e1d59b5dff
Avoid setting the static cache during the servo traversal. r=heycam
https://hg.mozilla.org/mozilla-central/rev/45e1d59b5dff
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.