1349815 - stylo: Gecko_GetLookAndFeelSystemColor mutates static data

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P1)

Description

[Bobby Holley (:bholley)]

See bug 1294915 comment 51.

Comment 1

[Bobby Holley (:bholley)]

Attachment: Part 1 - Explicitly initialize the LookAndFeel machinery. v1

MozReview-Commit-ID: Auw2Kw2gBlE

Comment 2

[Bobby Holley (:bholley)]

Attachment: Part 2 - Avoid setting the static cache during the servo traversal. v1

MozReview-Commit-ID: E9XC4kaCVd2

Comment 3

[Bobby Holley (:bholley)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=79d055120af78984170ab96eee5e5d49fa9f416e

Comment 4

[Bobby Holley (:bholley)]

Comment on attachment 8850269 [details] [diff] [review]
Part 1 - Explicitly initialize the LookAndFeel machinery. v1

Ugh, this turned to be a PITA. LayoutStatics is too late, since this stuff gets used during XRE init. However, doing it in XPCOM init runs afoul of content pref whitelist.

I'm just going to throw in the towel on this one.

Comment 5

[Bobby Holley (:bholley)]

Attachment: Avoid setting the static cache during the servo traversal. v2

MozReview-Commit-ID: E9XC4kaCVd2

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45e1d59b5dff
Avoid setting the static cache during the servo traversal. r=heycam

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/45e1d59b5dff