stylo: Gecko_GetLookAndFeelSystemColor mutates static data

RESOLVED FIXED in Firefox 55

Status

()

Core
CSS Parsing and Computation
P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: bholley, Assigned: bholley)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Comment 1

a year ago
Created attachment 8850269 [details] [diff] [review]
Part 1 - Explicitly initialize the LookAndFeel machinery. v1

MozReview-Commit-ID: Auw2Kw2gBlE
Attachment #8850269 - Flags: review?(masayuki)
(Assignee)

Comment 2

a year ago
Created attachment 8850270 [details] [diff] [review]
Part 2 - Avoid setting the static cache during the servo traversal. v1

MozReview-Commit-ID: E9XC4kaCVd2
Attachment #8850270 - Flags: review?(masayuki)
(Assignee)

Comment 4

a year ago
Comment on attachment 8850269 [details] [diff] [review]
Part 1 - Explicitly initialize the LookAndFeel machinery. v1

Ugh, this turned to be a PITA. LayoutStatics is too late, since this stuff gets used during XRE init. However, doing it in XPCOM init runs afoul of content pref whitelist.

I'm just going to throw in the towel on this one.
Attachment #8850269 - Attachment is obsolete: true
Attachment #8850269 - Flags: review?(masayuki)
(Assignee)

Comment 5

a year ago
Created attachment 8850282 [details] [diff] [review]
Avoid setting the static cache during the servo traversal. v2

MozReview-Commit-ID: E9XC4kaCVd2
Attachment #8850282 - Flags: review?(cam)
(Assignee)

Updated

a year ago
Attachment #8850270 - Attachment is obsolete: true
Attachment #8850270 - Flags: review?(masayuki)
Attachment #8850282 - Flags: review?(cam) → review+

Comment 6

a year ago
Pushed by bholley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/45e1d59b5dff
Avoid setting the static cache during the servo traversal. r=heycam

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/45e1d59b5dff
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.