1349856 - Reinstate proper usage of mReflowCause

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Nicholas Nethercote [inactive]]

Bug 1322553 introduced GeckoProfilerTracingRAII. Part 2 converted a bunch of
places to use it, but messed one of them up:

> -          profiler_tracing("Paint", "Reflow", Move(mReflowCause), TRACING_INTERVAL_START);
> +          tracingLayoutFlush.emplace("Paint", "Reflow");

The Move(mReflowCause) was erroneously deleted. (There was a similar case with
Move(mStyleCause) that was not deleted.)

This patch reinstates the Move(mReflowCause).

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Reinstate proper usage of mReflowCause

Comment 2

[Nicholas Nethercote [inactive]]

Assuming this is valid, it should be backported to Aurora (54) and Beta (53).

Comment 3

[Markus Stange [:mstange]]

It's valid, but the impact is limited because the perf.html UI doesn't expose this piece of information yet.

Comment 4

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/98c248833c4da778bea843ada7c666f54430952c
Bug 1349856 - Reinstate proper usage of mReflowCause. r=froydnj.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/98c248833c4d

Comment 6

[Nicholas Nethercote [inactive]]

Comment on attachment 8850352 [details] [diff] [review]
Reinstate proper usage of mReflowCause

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1322553

[User impact if declined]: Future versions of the profiler might be lacking information. (Current versions don't display the info collected by the buggy line of code.)

[Is this code covered by automated tests?]: Sort of? Not sure.

[Has the fix been verified in Nightly?]: The fixed code is in Nightly, but the line is not really used at the moment.

[Needs manual test from QE? If yes, steps to reproduce]: No.

[List of other uplifts needed for the feature/fix]: None.

[Is the change risky?]: No.

[Why is the change risky/not risky?]: Tiny change, obviously correct.

[String changes made/needed]: None.

Comment 7

[Gerry Chang [:gchang]]

Comment on attachment 8850352 [details] [diff] [review]
Reinstate proper usage of mReflowCause

This patch can help get correct information. Aurora54+ & Beta53+.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/58fe3ca31f9e

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a48c5cd45340

Comment 10

[Andrei Vaida [:avaida]]

Setting qe-verify- based on Nicholas' assessment on manual testing needs (see Comment 6).