Open
Bug 1349863
Opened 8 years ago
Updated 2 years ago
Enable test262 agent tests (Atomics/wait, Atomics/notify) in browser integration testing
Categories
(Core :: JavaScript Engine, enhancement, P3)
Core
JavaScript Engine
Tracking
()
NEW
Tracking | Status | |
---|---|---|
firefox55 | --- | affected |
People
(Reporter: lth, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
54.33 KB,
patch
|
Details | Diff | Splinter Review |
Currently (see bug 1346068 comment 14) agent tests are disabled in the browser because the test cases are not suitable for the browser and the $262.agent framework is insufficient for dealing with a browser. Work items: - fix $262.agent framework upstream (tc39/test262#928) - fix the test cases upstream (ditto) - fix our implementation of $262.agent in js/src/tests/test262-host.js and js/src/tests/test262/shell.js - remove the opt-outs in js/src/tests/jstests.list
Reporter | ||
Comment 1•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6c0d83e7ba5b80e56bb54a88b6b4ff3c8df25b3e
Reporter | ||
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c18d6eaf11df973ad0d56c78f5706ad19580f0a2
Reporter | ||
Comment 3•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=282e5f185da3e581413dab572a850963ed90f4d9
Reporter | ||
Comment 4•8 years ago
|
||
This has a new harness with a new API and rewritten test cases. It is *roughly* right and it passes locally when run in a browser with a simplified context, but fails on try, see the links in previous comments. The error is invariably that 'no output' is produced for the test cases. I think that what's most likely happening is that when $262.agent.start() returns to the event loop, as it must for the workers to be created properly, and also when it tries to wait for results from the workers, then the test runner may conclude that the test is done (because the script returned). But the only way to determine that is either to see test output, or to time out.
Assignee: nobody → lhansen
Comment 5•6 years ago
|
||
I'm updating test262. It looks like the API being tested here has changed, and basically none of the tests will run for us anymore. I'm going to disable them in jstests.list.
Summary: Enable test262 agent tests (Atomics/wait, Atomics/wake) in browser integration testing → Enable test262 agent tests (Atomics/wait, Atomics/notify) in browser integration testing
Reporter | ||
Comment 6•6 years ago
|
||
Bug 1470490 is about renaming wait as notify, I hope nothing else is a problem. And the rename (really - introduce an alias, for now) is all but trivial. And that bug should be unblocked now.
Reporter | ||
Updated•6 years ago
|
Assignee: lhansen → nobody
Comment 7•5 years ago
•
|
||
If this should continue to block bug 1477743 let me know. In that case we need to get this prioritized somehow.
Blocks: 1563480
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•