Closed
Bug 1349878
Opened 8 years ago
Closed 8 years ago
Remove unused nsILocaleService.h and nsILocale.h from mailnews
Categories
(MailNews Core :: Backend, enhancement)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 55.0
People
(Reporter: m_kato, Assigned: jorgk-bmo)
References
Details
Attachments
(1 file)
|
2.95 KB,
patch
|
aceman
:
review+
|
Details | Diff | Splinter Review |
The following cpp files includes nsILocaleService.h and nsILocale.h, but both interface isn't used. Please remove this #include.
mailnews/addrbook/src/nsAbView.cpp
mailnews/base/util/nsMsgDBFolder.cpp
mailnews/compose/src/nsMsgCompose.cpp
mailnews/db/msgdb/src/nsMsgDatabase.cpp
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → jorgk
|
|
Assignee | |
Comment 1•8 years ago
|
||
Makoto-san, thank you for reporting this. I think I left these behind in bug 1325745.
If you don't mind, you could CC me on similar bugs straight away.
Attachment #8850655 -
Flags: review?(acelists)
Comment on attachment 8850655 [details] [diff] [review]
1349878-remove-locale.patch
Review of attachment 8850655 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks, compiles for me.
Attachment #8850655 -
Flags: review?(acelists) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 55.0
|
|
Assignee | |
Comment 4•8 years ago
|
||
C-A (TB 54): https://hg.mozilla.org/releases/comm-aurora/rev/a480f4661a295b7ccf7a95e40f38bb62adc05645
Pushed to Aurora to trigger a build there.
You need to log in
before you can comment on or make changes to this bug.
Description
•