1349879 - Pass interfaces test even if ENABLE_INTL_API is turned off

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Makoto Kato [:m_kato] (PTO until 5/6)]

Need fix for interface tests when disable ICU since Android/arm runs mochitests.

dom/tests/mochitest/general/test_interfaces.html |
dom/workers/test/test_worker_interfaces.html 
dom/workers/test/serviceworkers/test_serviceworker_interfaces.html |

Comment 2

[Makoto Kato [:m_kato] (PTO until 5/6)]

Attachment: Bug 1349879 - Intl object is hidden on Android beta and release channel.

Some interface tests into mochitest is failure on android beta and release.

test_serviceworker_interfaces.js has nonReleaseAndroid flag, so we should use it into test_interfaces.js and test_worker_interfaces.js

Review commit: https://reviewboard.mozilla.org/r/125382/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125382/

Comment 3

[Makoto Kato [:m_kato] (PTO until 5/6)]

I forget to check x86 build.  I cancel review.

Comment 4

[Makoto Kato [:m_kato] (PTO until 5/6)]

(Since x86 doesn't run mochitest, so it works well.  But I don't run this on try server.  So until I pass this on all builder, I cancel reivew)

Comment 5

[Makoto Kato [:m_kato] (PTO until 5/6)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6cb7c65cdf809d0e7a1783672f51d19bd7679a81

Comment 6

[Makoto Kato [:m_kato] (PTO until 5/6)]

Attachment: Bug 1349879 - Intl object is hidden on Android beta and release channel.

Some interface tests into mochitest is failure on android beta and release.

test_serviceworker_interfaces.js has nonReleaseAndroid flag, so we should use it into test_interfaces.js and test_worker_interfaces.js

Review commit: https://reviewboard.mozilla.org/r/125924/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125924/

Comment 7

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8853885 [details]
Bug 1349879 - Intl object is hidden on Android beta and release channel.

https://reviewboard.mozilla.org/r/125924/#review128562

Am I the right person to review this? Looks fine, but seems like someone related to the code should r+ as well.

Comment 8

[Jeff Walden [:Waldo]]

Comment on attachment 8853885 [details]
Bug 1349879 - Intl object is hidden on Android beta and release channel.

https://reviewboard.mozilla.org/r/125924/#review129126

::: dom/workers/test/test_worker_interfaces.js:270
(Diff revision 1)
> +            (entry.nonReleaseAndroid === !(isAndroid && !isRelease) && isAndroid) ||
>              (entry.desktop === !isDesktop) ||
> -            (entry.android === !isAndroid && !entry.nightlyAndroid) ||
> +            (entry.android === !isAndroid && !entry.nonReleaseAndroid && !entry.nightlyAndroid) ||
>              (entry.release === !isRelease) ||
>              (entry.isSecureContext === !isSecureContext) ||
>              entry.disabled) {

Ugh, this existing code is nearly unreadable.  :-(  But this looks right as far as the minimal modification of existing code goes, I guess.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d05398f81735
Intl object is hidden on Android beta and release channel. r=snorp,Waldo

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d05398f81735

Comment 11

[Makoto Kato [:m_kato] (PTO until 5/6)]

Comment on attachment 8853885 [details]
Bug 1349879 - Intl object is hidden on Android beta and release channel.

Approval Request Comment
[Feature/Bug causing the regression]:
bug 1343725

[User impact if declined]:
Our buildbot doesn't pass mochitest on beta / release channel.

[Is this code covered by automated tests?]:
Yes.  This is test issue.

[Has the fix been verified in Nightly?]:
Yes, mochitest is passed

[Needs manual test from QE? If yes, steps to reproduce]: 
No, this is automated test issue

[List of other uplifts needed for the feature/fix]:
N/A

[Is the change risky?]:
No

[Why is the change risky/not risky?]:
This is automated test issue.

[String changes made/needed]:
No

Comment 12

[Phil Ringnalda (:philor)]

Comment on attachment 8853885 [details]
Bug 1349879 - Intl object is hidden on Android beta and release channel.

You don't need to request approval for test-only changes, they can just be landed with "a=test-only".

Comment 13

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/20c110248317