Closed Bug 1349879 Opened 3 years ago Closed 3 years ago

Pass interfaces test even if ENABLE_INTL_API is turned off

Categories

(Firefox for Android :: General, defect)

54 Branch
ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 55
Tracking Status
firefox53 --- unaffected
firefox54 --- fixed
firefox55 --- fixed

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

Attachments

(1 file, 1 obsolete file)

Need fix for interface tests when disable ICU since Android/arm runs mochitests.

dom/tests/mochitest/general/test_interfaces.html |
dom/workers/test/test_worker_interfaces.html 
dom/workers/test/serviceworkers/test_serviceworker_interfaces.html |
Assignee: nobody → m_kato
Duplicate of this bug: 1351191
Attachment #8853301 - Attachment is obsolete: true
Attachment #8853301 - Flags: review?(snorp)
I forget to check x86 build.  I cancel review.
(Since x86 doesn't run mochitest, so it works well.  But I don't run this on try server.  So until I pass this on all builder, I cancel reivew)
Comment on attachment 8853885 [details]
Bug 1349879 - Intl object is hidden on Android beta and release channel.

https://reviewboard.mozilla.org/r/125924/#review128562

Am I the right person to review this? Looks fine, but seems like someone related to the code should r+ as well.
Attachment #8853885 - Flags: review?(snorp) → review+
Attachment #8853885 - Flags: review?(jwalden+bmo)
Comment on attachment 8853885 [details]
Bug 1349879 - Intl object is hidden on Android beta and release channel.

https://reviewboard.mozilla.org/r/125924/#review129126

::: dom/workers/test/test_worker_interfaces.js:270
(Diff revision 1)
> +            (entry.nonReleaseAndroid === !(isAndroid && !isRelease) && isAndroid) ||
>              (entry.desktop === !isDesktop) ||
> -            (entry.android === !isAndroid && !entry.nightlyAndroid) ||
> +            (entry.android === !isAndroid && !entry.nonReleaseAndroid && !entry.nightlyAndroid) ||
>              (entry.release === !isRelease) ||
>              (entry.isSecureContext === !isSecureContext) ||
>              entry.disabled) {

Ugh, this existing code is nearly unreadable.  :-(  But this looks right as far as the minimal modification of existing code goes, I guess.
Attachment #8853885 - Flags: review?(jwalden+bmo) → review+
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/d05398f81735
Intl object is hidden on Android beta and release channel. r=snorp,Waldo
https://hg.mozilla.org/mozilla-central/rev/d05398f81735
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Comment on attachment 8853885 [details]
Bug 1349879 - Intl object is hidden on Android beta and release channel.

Approval Request Comment
[Feature/Bug causing the regression]:
bug 1343725

[User impact if declined]:
Our buildbot doesn't pass mochitest on beta / release channel.

[Is this code covered by automated tests?]:
Yes.  This is test issue.

[Has the fix been verified in Nightly?]:
Yes, mochitest is passed

[Needs manual test from QE? If yes, steps to reproduce]: 
No, this is automated test issue

[List of other uplifts needed for the feature/fix]:
N/A

[Is the change risky?]:
No

[Why is the change risky/not risky?]:
This is automated test issue.

[String changes made/needed]:
No
Attachment #8853885 - Flags: approval-mozilla-aurora?
Comment on attachment 8853885 [details]
Bug 1349879 - Intl object is hidden on Android beta and release channel.

You don't need to request approval for test-only changes, they can just be landed with "a=test-only".
Attachment #8853885 - Flags: approval-mozilla-aurora?
You need to log in before you can comment on or make changes to this bug.