1350144 - Remove unicode from user agent strings

Status: RESOLVED FIXED

(Firefox for iOS :: General, enhancement, P1)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

We currently use the product name in our user agents. This means the the UA can contain 'Firefox β'.

This can confuse some tools like NGINX so the request is to replace 'Firefox β' with 'Firefox Beta' and 'Firefox α' with 'Firefox Nightly' in the user agents.

I think it is fine to keep the unicode on the home screen?

Comment 1

[Richard Newman [:rnewman]]

Note that this doesn't just confuse nginx, it's actually invalid HTTP. We have crashed webservers before by doing exactly this.

Comment 2

[Bob Micheletto [:bobm]]

Nginx logs the present iOS Beta user agent as "Firefox-iOS-Sync/7.0 (Firefox".

Comment 3

[Aaron Train [:aaronmt]]

(In reply to Bob Micheletto [:bobm] from comment #2)
> Nginx logs the present iOS Beta user agent as "Firefox-iOS-Sync/7.0
> (Firefox".

That's even more concerning.

Comment 4

[Stephan Leroux [:sleroux]]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2570

Comment 5

[Stephan Leroux [:sleroux]]

Attachment: master PR https://github.com/mozilla-mobile/firefox-ios/pull/2569

Comment 6

[Stephan Leroux [:sleroux]]

master 04d348d93cf516ed9174f9342d21a52fd0e5d85d
v7.x 2c7fc2751b8bd8bc4e2b86b76d16c7ea321749d9