1350146 - Include application channel, version and build number in all user agent strings

Status: RESOLVED FIXED

(Firefox for iOS :: General, enhancement, P1)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

We currently only include the app version number in our user agent strings.

To be able to better recoginize specific builds, specially for betas where the version number does not change but the build number does, we need to include both version and and build number.

This should apply to all our user agents. For the WKWebView and also for all the clients that we have like FxA, Push, etc.

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Updated the bug to mention that we should include three components in all our UAs:

 - Channel (Firefox, Firefox Beta, Firefox Nightly)
 - Version 7.0
 - Build 2150

Comment 2

[Stephan Leroux [:sleroux]]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2556

Comment 4

[Stephan Leroux [:sleroux]]

See :rfk's comment about some additional info we should send https://bugzilla.mozilla.org/show_bug.cgi?id=1350769#c4

Comment 5

[Stephan Leroux [:sleroux]]

Hey Ryan,

I've amended my patch to include the device model and system version in our FxA/Sync/Token client user agents [1]

For example, the user agent when talking to the FxA server will now look something like this:

Firefox-iOS-Sync/8.0b1 (iPad; iPhone OS 10.2) (Firefox)	
Firefox-iOS-Sync/8.0b1 (iPad; iPhone OS 10.2) (Nightly)	
Firefox-iOS-Sync/8.0b1 (iPhone; iPhone OS 10.2) (Firefox)

I followed a similar format we use for our web user agent where they enclosed the device model and system in brackets with the device being the first string and the second being the system version. 

Is this what you were looking for in https://bugzilla.mozilla.org/show_bug.cgi?id=1350769?	

[1] https://github.com/mozilla-mobile/firefox-ios/pull/2556/commits/779501b585c4c4454ef52387320bdc472abc4eea

Comment 6

[Ryan Kelly [:rfkelly]]

> Is this what you were looking for in https://bugzilla.mozilla.org/show_bug.cgi?id=1350769?

Yes, this looks great, thanks!

Comment 7

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8850972 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2556

LGTM

Comment 8

[Stephan Leroux [:sleroux]]

master a18df199a08a31407973b8c67738dc9aca56cc98
v7.x 56c1147