1350211 - Re-enable native stack walking on Android

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Nicholas Nethercote [inactive]]

Bug 1339695 part 8 accidentally disabled native stack walking on Android by
using GP_arm_android instead of GP_PLAT_arm_android in a #if. This patch fixes
that. It also fixes a couple of compile errors that crept into the relevant
code while it was disabled.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Re-enable native stack walking on Android

Comment 2

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/096b992d0b34a34e4575927e7f2d24201bd2e1f5
Bug 1350211 - Re-enable native stack walking on Android. r=mstange.

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/096b992d0b34

Comment 4

[Nicholas Nethercote [inactive]]

Comment on attachment 8850850 [details] [diff] [review]
Re-enable native stack walking on Android

Approval Request Comment

[Feature/Bug causing the regression]: Bug 1339695

[User impact if declined]: No native stack walking done by the profiler on Android.

[Is this code covered by automated tests?]: Yes.

[Has the fix been verified in Nightly?]: No.

[Needs manual test from QE? If yes, steps to reproduce]: No.

[List of other uplifts needed for the feature/fix]: None.

[Is the change risky?]: No.

[Why is the change risky/not risky?]: Very simple patch, just re-enables some code that was accidentally disable; and the regression is recent.

[String changes made/needed]: None.

Comment 5

[Gerry Chang [:gchang]]

Comment on attachment 8850850 [details] [diff] [review]
Re-enable native stack walking on Android

Re-enable native stack walking on Android. Aurora54+.

Comment 6

[Carsten Book [:Tomcat]]

has problems to apply to aurora:

grafting 407897:096b992d0b34 "Bug 1350211 - Re-enable native stack walking on Android. r=mstange."
merging tools/profiler/core/platform.cpp
warning: conflicts while merging tools/profiler/core/platform.cpp! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue'

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e23fd0f551cb

Comment 8

[Ryan VanderMeulen [:RyanVM]]

The merge conflict was easy to rebase around, but there was bustage underneath. Backed out.
https://treeherder.mozilla.org/logviewer.html#?job_id=87084445&repo=mozilla-aurora

https://hg.mozilla.org/releases/mozilla-aurora/rev/6ea48bfb090196752dbbcb1d8707080e51623f19

Comment 9

[Nicholas Nethercote [inactive]]

Attachment: Re-enable native stack walking on Android

Comment 10

[Nicholas Nethercote [inactive]]

Comment on attachment 8852308 [details] [diff] [review]
Re-enable native stack walking on Android

This is the m-c patch rebased for aurora.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4d6b735d8a4b