Improve TickSample

RESOLVED FIXED in Firefox 55

Status

()

Core
Gecko Profiler
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 months ago
A follow-up to bug 1344169.
(Assignee)

Comment 1

3 months ago
Created attachment 8850851 [details] [diff] [review]
Improve TickSample

This patch does the following.

- Renames TickSample's members to mFoo style.

- Changes TickSample's constructor to set mTimeStamp.

- Moves TickSample creation from
  SamplerThread::SuspendAndSampleAndResumeThread() to SamplerThread::Run(), so
  it's not repeated for each platform.

- Changes TickSample::PopulateContext() so it takes a |tick_context_t*|
  parameter, which avoids having to cast from |void*|.
Attachment #8850851 - Flags: review?(jseward)
Comment on attachment 8850851 [details] [diff] [review]
Improve TickSample

Review of attachment 8850851 [details] [diff] [review]:
-----------------------------------------------------------------

Another nice cleanup.  Looks fine to me.
Attachment #8850851 - Flags: review?(jseward) → review+
(Assignee)

Comment 3

3 months ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/c15ba7e706c254a5cbc5255da104aac2cb7d1f1e
Bug 1350212 - Improve TickSample. r=jseward.

Comment 4

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c15ba7e706c2
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.