Closed Bug 1350212 Opened 4 years ago Closed 4 years ago

Improve TickSample

Categories

(Core :: Gecko Profiler, enhancement)

Product:
Core
Component:
Gecko Profiler
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: njn, Assigned: njn)

Details

Attachments

(1 file)

Improve TickSample
34.75 KB, patch
jseward
: review+
Details | Diff | Splinter Review 
This patch does the following.

- Renames TickSample's members to mFoo style.

- Changes TickSample's constructor to set mTimeStamp.

- Moves TickSample creation from
  SamplerThread::SuspendAndSampleAndResumeThread() to SamplerThread::Run(), so
  it's not repeated for each platform.

- Changes TickSample::PopulateContext() so it takes a |tick_context_t*|
  parameter, which avoids having to cast from |void*|.
Attachment #8850851 - Flags: review?(jseward)
Comment on attachment 8850851 [details] [diff] [review]
Improve TickSample

Review of attachment 8850851 [details] [diff] [review]:
-----------------------------------------------------------------

Another nice cleanup.  Looks fine to me.
Attachment #8850851 - Flags: review?(jseward) → review+
https://hg.mozilla.org/mozilla-central/rev/c15ba7e706c2
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.