Closed
Bug 1350212
Opened 9 years ago
Closed 9 years ago
Improve TickSample
Categories
(Core :: Gecko Profiler, enhancement)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(1 file)
|
34.75 KB,
patch
|
jseward
:
review+
|
Details | Diff | Splinter Review |
A follow-up to bug 1344169.
|
Assignee | |
Comment 1•9 years ago
|
||
This patch does the following.
- Renames TickSample's members to mFoo style.
- Changes TickSample's constructor to set mTimeStamp.
- Moves TickSample creation from
SamplerThread::SuspendAndSampleAndResumeThread() to SamplerThread::Run(), so
it's not repeated for each platform.
- Changes TickSample::PopulateContext() so it takes a |tick_context_t*|
parameter, which avoids having to cast from |void*|.
Attachment #8850851 -
Flags: review?(jseward)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8850851 [details] [diff] [review]
Improve TickSample
Review of attachment 8850851 [details] [diff] [review]:
-----------------------------------------------------------------
Another nice cleanup. Looks fine to me.
Attachment #8850851 -
Flags: review?(jseward) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c15ba7e706c254a5cbc5255da104aac2cb7d1f1e
Bug 1350212 - Improve TickSample. r=jseward.
|
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•