Closed Bug 1350301 Opened 7 years ago Closed 7 years ago

UI display for Dominators with Call Stack prints text lines overlapping each other

Categories

(DevTools :: Memory, defect, P2)

defect

Tracking

(firefox-esr52 wontfix, firefox53 wontfix, firefox54 verified, firefox55 verified)

VERIFIED FIXED
Firefox 55
Tracking Status
firefox-esr52 --- wontfix
firefox53 --- wontfix
firefox54 --- verified
firefox55 --- verified

People

(Reporter: jujjyl, Assigned: jujjyl)

References

Details

Attachments

(4 files)

STR:

1. Visit https://s3.amazonaws.com/mozilla-games/ZenGarden/EpicZenGarden.html
2. Open Devtools on Memory, enable "Record call stacks" checkbox and set View: to Dominators and Label by: to Call Stack.
3. While keeping the Mmemory tab open, Reload the page
4. Click on the Snapshot icon.

The captured profile renders its text overlapped so that it is unreadable. See the attached screenshot.
To clarify, this is not an issue of having resized the window to too small size. Maximizing the window on a 4K display still overlaps the text.
Assignee: nobody → jujjyl
Is this the reason for this? I am looking for this error for a long time.

Thank you 
-http://www.evwedding.com/
It's not reproducing on my Mac on Nightly.
Nevermind! Didn't follow the STR properly.
Here is the fix applied.
Priority: -- → P2
Comment on attachment 8871530 [details]
Bug 1350301 - Fix broken layout of dominator view with callstacks enabled;

https://reviewboard.mozilla.org/r/143000/#review146996

Thanks, Greg!
Attachment #8871530 - Flags: review?(nfitzgerald) → review+
Pushed by gtatum@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/116b26438078
Fix broken layout of dominator view with callstacks enabled; r=fitzgen
Comment on attachment 8871530 [details]
Bug 1350301 - Fix broken layout of dominator view with callstacks enabled;

Approval Request Comment
[Feature/Bug causing the regression]:

Bug 1251033 set the DOM element to have the wrong display type.

[User impact if declined]:

The layout for the dominator view with callstacks in the memory devtools will be broken.

[Is this code covered by automated tests?]:

The tool is, but this is a style change to the component.

[Has the fix been verified in Nightly?]:

No.

[Needs manual test from QE? If yes, steps to reproduce]: 

Yes.

STR:

1. Visit https://s3.amazonaws.com/mozilla-games/ZenGarden/EpicZenGarden.html
2. Open Devtools on Memory, enable "Record call stacks" checkbox and set View: to Dominators and Label by: to Call Stack.
3. While keeping the Mmemory tab open, Reload the page
4. Click on the Snapshot icon.

The captured profile renders its text overlapped so that it is unreadable. See the attached screenshot

[List of other uplifts needed for the feature/fix]:

None.

[Is the change risky?]:

No

[Why is the change risky/not risky?]:

This is a slight style tweak to a single devtools component with relatively low opens.

[String changes made/needed]:

None.
Attachment #8871530 - Flags: approval-mozilla-beta?
Attachment #8871530 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/116b26438078
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Comment on attachment 8871530 [details]
Bug 1350301 - Fix broken layout of dominator view with callstacks enabled;

Aurora doesn't exist anymore.
Attachment #8871530 - Flags: approval-mozilla-aurora?
Setting qe-verify+, see comment 10 for STR.
Blocks: 1251033
Flags: qe-verify+
Comment on attachment 8871530 [details]
Bug 1350301 - Fix broken layout of dominator view with callstacks enabled;

css fix for devtools/memory, should be in 54.0b12
Attachment #8871530 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
I have reproduced this bug with Nightly 55.0a1 (2017-03-24) (64-bit) on Ubuntu 16.04 LTS 64 Bit!

The fix's fix is verified with latest Beta!

Build ID 	: 20170529095024
User Agent 	: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Firefox/54.0
QA Whiteboard: [bugday-20170531]
I have reproduced this bug with Nightly 55.0a1 (2017-03-24) (64-bit) on Ubuntu 16.04 LTS 64 Bit!

The fix's fix is verified with latest Nightly!

Build ID 	: 20170531100318
User Agent 	: Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0
I have successfully reproduced the bug in firefox Nightly 55.0a1 (2017-03-24) (32-bit) with windows 10 (32 bit) 

Verified as fixed with latest nightly 55.0a1 (2017-05-31) (32-bit)

Build ID:   20170531030204
Mozilla/5.0 (Windows NT 10.0; rv:55.0) Gecko/20100101 Firefox/55.0

and Verified as fixed with latest beta 54.0b12 (32-bit)
Build ID:    20170529025116
Mozilla/5.0 (Windows NT 10.0; rv:54.0) Gecko/20100101 Firefox/54.0
As per Comment 16 & Comment 17 & Comment 18, I am marking this bug as verified fixed.
Status: RESOLVED → VERIFIED
I have reproduced the issue mentioned in comment 0 using Firefox 55.0a1 (Build Id:20170324030205).

This issue is verified fixed on Firefox 55.0a1 (Build Id:20170606030207) and Firefox 54.0 (Build Id:20170605134926) on Windows 10 64bit, macOS 10.11.6 and Ubuntu 14.04 32bit
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: