1350301 - UI display for Dominators with Call Stack prints text lines overlapping each other

Status: VERIFIED FIXED

(DevTools :: Memory, defect, P2)

Description

[Jukka Jylänki]

Attachment: memory_dominators_by_callstack.png

STR:

1. Visit https://s3.amazonaws.com/mozilla-games/ZenGarden/EpicZenGarden.html
2. Open Devtools on Memory, enable "Record call stacks" checkbox and set View: to Dominators and Label by: to Call Stack.
3. While keeping the Mmemory tab open, Reload the page
4. Click on the Snapshot icon.

The captured profile renders its text overlapped so that it is unreadable. See the attached screenshot.

Comment 1

[Jukka Jylänki]

Attachment: memory_dominators_by_callstack_maximized_3840_2160.png

To clarify, this is not an issue of having resized the window to too small size. Maximizing the window on a 4K display still overlaps the text.

Comment 2

[lpldressev]

Is this the reason for this? I am looking for this error for a long time.

Thank you 
-http://www.evwedding.com/

Comment 3

[Greg Tatum [:gregtatum]]

It's not reproducing on my Mac on Nightly.

Comment 4

[Greg Tatum [:gregtatum]]

Nevermind! Didn't follow the STR properly.

Comment 5

[Greg Tatum [:gregtatum]]

Attachment: Bug 1350301 - Fix broken layout of dominator view with callstacks enabled;

The shared Frame component appears to set the containing element to be a
flex component, while the table view with the dominators expects an
inline-block element. This appears to have been broken for quite
some time with Bug 1251033.

Review commit: https://reviewboard.mozilla.org/r/143000/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143000/

Comment 6

[Greg Tatum [:gregtatum]]

Attachment: memory-callstacks-fix.png

Here is the fix applied.

Comment 7

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8871530 [details]
Bug 1350301 - Fix broken layout of dominator view with callstacks enabled;

https://reviewboard.mozilla.org/r/143000/#review146996

Thanks, Greg!

Comment 8

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Uplift?

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/116b26438078
Fix broken layout of dominator view with callstacks enabled; r=fitzgen

Comment 10

[Greg Tatum [:gregtatum]]

Comment on attachment 8871530 [details]
Bug 1350301 - Fix broken layout of dominator view with callstacks enabled;

Approval Request Comment
[Feature/Bug causing the regression]:

Bug 1251033 set the DOM element to have the wrong display type.

[User impact if declined]:

The layout for the dominator view with callstacks in the memory devtools will be broken.

[Is this code covered by automated tests?]:

The tool is, but this is a style change to the component.

[Has the fix been verified in Nightly?]:

No.

[Needs manual test from QE? If yes, steps to reproduce]: 

Yes.

STR:

1. Visit https://s3.amazonaws.com/mozilla-games/ZenGarden/EpicZenGarden.html
2. Open Devtools on Memory, enable "Record call stacks" checkbox and set View: to Dominators and Label by: to Call Stack.
3. While keeping the Mmemory tab open, Reload the page
4. Click on the Snapshot icon.

The captured profile renders its text overlapped so that it is unreadable. See the attached screenshot

[List of other uplifts needed for the feature/fix]:

None.

[Is the change risky?]:

No

[Why is the change risky/not risky?]:

This is a slight style tweak to a single devtools component with relatively low opens.

[String changes made/needed]:

None.

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/116b26438078

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8871530 [details]
Bug 1350301 - Fix broken layout of dominator view with callstacks enabled;

Aurora doesn't exist anymore.

Comment 13

[Julien Cristau [:jcristau]]

Setting qe-verify+, see comment 10 for STR.

Comment 14

[Julien Cristau [:jcristau]]

Comment on attachment 8871530 [details]
Bug 1350301 - Fix broken layout of dominator view with callstacks enabled;

css fix for devtools/memory, should be in 54.0b12

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e62e4db3e31d

Comment 16

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 55.0a1 (2017-03-24) (64-bit) on Ubuntu 16.04 LTS 64 Bit!

The fix's fix is verified with latest Beta!

Build ID 	: 20170529095024
User Agent 	: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Firefox/54.0

Comment 17

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 55.0a1 (2017-03-24) (64-bit) on Ubuntu 16.04 LTS 64 Bit!

The fix's fix is verified with latest Nightly!

Build ID 	: 20170531100318
User Agent 	: Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0

Comment 18

[Md. Rahimul Islam]

I have successfully reproduced the bug in firefox Nightly 55.0a1 (2017-03-24) (32-bit) with windows 10 (32 bit) 

Verified as fixed with latest nightly 55.0a1 (2017-05-31) (32-bit)

Build ID:   20170531030204
Mozilla/5.0 (Windows NT 10.0; rv:55.0) Gecko/20100101 Firefox/55.0

and Verified as fixed with latest beta 54.0b12 (32-bit)
Build ID:    20170529025116
Mozilla/5.0 (Windows NT 10.0; rv:54.0) Gecko/20100101 Firefox/54.0

Comment 19

[Md. Rahimul Islam]

As per Comment 16 & Comment 17 & Comment 18, I am marking this bug as verified fixed.

Comment 20

[Emil Ghitta, QA [:emilghitta]]

I have reproduced the issue mentioned in comment 0 using Firefox 55.0a1 (Build Id:20170324030205).

This issue is verified fixed on Firefox 55.0a1 (Build Id:20170606030207) and Firefox 54.0 (Build Id:20170605134926) on Windows 10 64bit, macOS 10.11.6 and Ubuntu 14.04 32bit