1350330 - Crash in mozalloc_abort | NS_DebugBreak | mozilla::ipc::LogicError | mozilla::layers::PLayerTransactionChild::SendReleaseCompositable

Status: RESOLVED FIXED

(Core :: Graphics, defect, P3)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is 
report bp-f89de6d5-9b25-48f2-9bbd-01c192170321.
=============================================================

Seen while looking at Nightly crash stats. These crashes started with 20170320030209: http://bit.ly/2nLOn3u

Possible regression range based on Build ID: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e1576dd8bd9d3a4ca418cf347133b8a4957ddeca&tochange=1b9293be51637f841275541d8991314ca56561a5

Comment 1

[Bas Schouten (:bas.schouten)]

This line appears to be some kind of state change. Nical, is it possible the forwarder is already being destroyed here or something along those lines?

CC'ing Milan, listed as critical.

Comment 2

[Vincent Liu[:vliu]]

Attachment: 0001-Bug-1350330-Make-sure-IPC-channel-still-Open-before-.patch

Hi David,
Do you think we can have this IPC check and see if it can fix this crash?

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8857317 [details] [diff] [review]
0001-Bug-1350330-Make-sure-IPC-channel-still-Open-before-.patch

Review of attachment 8857317 [details] [diff] [review]:
-----------------------------------------------------------------

Yup, good catch.

Comment 4

[Vincent Liu[:vliu]]

try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5b0a5f611da5d8064246df38eca30eccdd03f041&selectedJob=92021997

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1574c02ea13f
Make sure IPC channel still Open before sending IPC message. r=dvander

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1574c02ea13f

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Looks like the code in question goes back to 53, but this only started crashing in 55? Do we need to consider this for backport to 54 or can it ride the 55 train?

Comment 8

[Vincent Liu[:vliu]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #7)
> Looks like the code in question goes back to 53, but this only started
> crashing in 55? Do we need to consider this for backport to 54 or can it
> ride the 55 train?

Yes, I think we can backport to 54. It is no risky to have this uplift.

Comment 9

[Vincent Liu[:vliu]]

Comment on attachment 8857317 [details] [diff] [review]
0001-Bug-1350330-Make-sure-IPC-channel-still-Open-before-.patch

Approval Request Comment
[Feature/Bug causing the regression]: bug 1323957
[User impact if declined]: Crash might happens
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]:
[Needs manual test from QE? If yes, steps to reproduce]: no 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: no
[Why is the change risky/not risky?]:Gecko has some other check like patch did.
[String changes made/needed]:

Comment 10

[Gerry Chang [:gchang]]

Comment on attachment 8857317 [details] [diff] [review]
0001-Bug-1350330-Make-sure-IPC-channel-still-Open-before-.patch

Fix a potential crash. Aurora54+.

Comment 11

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1388c6f3d0aa