1350355 - fdlibm should provide definition for u_int32_t and u_int64_t

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Petr Sumbera]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20170316213829

Steps to reproduce:

modules/fdlibm/src/math_private.h expects defined u_int32_t and u_int64_t.

u_int32_t and u_int64_t are not stdint.h types as can be seen here:
https://hg.mozilla.org/mozilla-central/rev/a446b4e60744

Another victim beside WINDOWS is also Solaris:
https://github.com/lkinley/Net-SSH-Perl/pull/4

We should provide more general definition.

Comment 1

[Petr Sumbera]

Attachment: Bug1350355.patch

Comment 2

[Tooru Fujisawa [:arai]]

Comment on attachment 8851018 [details] [diff] [review]
Bug1350355.patch

Review of attachment 8851018 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for your patch.

the file is automatically generated from modules/fdlibm/patches/*.patch, that's applied by modules/fdlibm/update.sh, after importing files from upstream by modules/fdlibm/import.sh (called from update.sh)

can you add the corresponding patch there, to make the change kept after the next update?

Comment 3

[Petr Sumbera]

Attachment: Bug1350355.patch

Comment 4

[Tooru Fujisawa [:arai]]

Comment on attachment 8851536 [details] [diff] [review]
Bug1350355.patch

Review of attachment 8851536 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you again :)

sorry I forgot to say that the patch also needs the actual change to the file,
we can use the previous patch as Part 1, and this patch as Part 2.
(if you want to fold them into single patch, let me know)

I'll push this to try server shortly.

Comment 5

[Tooru Fujisawa [:arai]]

here's try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=60e6e1f38463aab47e194b79b035fc2ff3192e9b

it may take a few hours.

Comment 6

[Petr Sumbera]

So what was the result? Can this be pushed please?

Comment 7

[Tooru Fujisawa [:arai]]

yes, you can add checkin-needed keyword to this bug :)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b2893936478f
fdlibm should provide definition for u_int32_t and u_int64_t. r=arai

Comment 9

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/b2893936478f