Closed Bug 1350433 Opened 3 years ago Closed 3 years ago

Don't call WorkerPrivate::WorkerName() to get service worker scope

Categories

(Core :: DOM: Service Workers, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: bkelly, Assigned: bkelly)

References

Details

Attachments

(1 file)

In bug 1293277 I want to change how we store the scope on a WorkerPrivate.  Today we do this by putting it in WorkerName().  That is ok, but a bit of a hack.  To make bug 1293277 easier I'd like to expose a separate ServiceWorkerScope() getter.  Today it will just look at mWorkerName.  In bug 1293277 I will make it look at my new thing.
This just makes existing code use a separate ServiceWorkerScope() method to get the scope out of a WorkerPrivate.  It still uses the same underlying storage today.  This will make it easier to refactor the scope storage in the future.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e764099b6283d7b0d0cfbb22f0c7d54514d47173
Attachment #8851099 - Flags: review?(bugmail)
Comment on attachment 8851099 [details] [diff] [review]
Expose WorkerPrivate::ServiceWorkerScope() instead of using WorkerName() all over the place. r=asuth

Review of attachment 8851099 [details] [diff] [review]:
-----------------------------------------------------------------

Regrettably, this limits clever comments referencing The Ting Tings' "That's Not My Name" going forward.
Attachment #8851099 - Flags: review?(bugmail) → review+
Pushed by bkelly@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1e329519364b
Expose WorkerPrivate::ServiceWorkerScope() instead of using WorkerName() all over the place. r=asuth
https://hg.mozilla.org/mozilla-central/rev/1e329519364b
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.