1350459 - Remove the [Throws] annotation from Window.navigator

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[(no longer active)]

nsGlobalWindow::GetNavigator() never touches its aError argument, so we should be able to remove the [Throws] annotation.

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi Ben,
Wanna have some fun with this?

Comment 2

[Ben Tian (inactive)]

Sure. Take it.

Comment 3

[Ben Tian (inactive)]

The nsGlobalWindow::GetNavigator() [1] from Window.webidl [2] conflicts with the other nsGlobalWindow::GetNavigator() [3] from nsPIDOMWindow [4] if aError argument is removed. Additional integration effort is required.

error: invalid covariant return type for ‘virtual mozilla::dom::Navigator* nsGlobalWindow::GetNavigator()’

[1] http://searchfox.org/mozilla-central/source/dom/base/nsGlobalWindow.h#927
[2] http://searchfox.org/mozilla-central/source/dom/webidl/Window.webidl#70
[3] http://searchfox.org/mozilla-central/source/dom/base/nsGlobalWindow.h#928
[4] http://searchfox.org/mozilla-central/source/dom/base/nsPIDOMWindow.h#567

Comment 4

[Ben Tian (inactive)]

Comment 3 conflict resolves since getter prefix "Get" is removed as no [Throws].

[1] https://developer.mozilla.org/en-US/docs/Mozilla/WebIDL_bindings#C_reflections_of_WebIDL_attributes

Comment 5

[Ben Tian (inactive)]

Attachment: Bug 1350459 - Remove the [Throws] annotation from Window.navigator,

Review commit: https://reviewboard.mozilla.org/r/128362/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/128362/

Comment 6

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8856410 [details]
Bug 1350459 - Remove the [Throws] annotation from Window.navigator,

https://reviewboard.mozilla.org/r/128362/#review132634

Comment 7

[Ben Tian (inactive)]

Comment on attachment 8856410 [details]
Bug 1350459 - Remove the [Throws] annotation from Window.navigator,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/128362/diff/1-2/

Comment 8

[Ben Tian (inactive)]

Try result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9fc29f1b08c6

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0bb5d2ed17ce
Remove the [Throws] annotation from Window.navigator, r=qdot

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0bb5d2ed17ce