Closed
Bug 1350459
Opened 8 years ago
Closed 8 years ago
Remove the [Throws] annotation from Window.navigator
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ben.tian)
Details
Attachments
(1 file)
nsGlobalWindow::GetNavigator() never touches its aError argument, so we should be able to remove the [Throws] annotation.
Assignee | ||
Comment 3•8 years ago
|
||
The nsGlobalWindow::GetNavigator() [1] from Window.webidl [2] conflicts with the other nsGlobalWindow::GetNavigator() [3] from nsPIDOMWindow [4] if aError argument is removed. Additional integration effort is required.
error: invalid covariant return type for ‘virtual mozilla::dom::Navigator* nsGlobalWindow::GetNavigator()’
[1] http://searchfox.org/mozilla-central/source/dom/base/nsGlobalWindow.h#927
[2] http://searchfox.org/mozilla-central/source/dom/webidl/Window.webidl#70
[3] http://searchfox.org/mozilla-central/source/dom/base/nsGlobalWindow.h#928
[4] http://searchfox.org/mozilla-central/source/dom/base/nsPIDOMWindow.h#567
Assignee | ||
Comment 4•8 years ago
|
||
Comment 3 conflict resolves since getter prefix "Get" is removed as no [Throws].
[1] https://developer.mozilla.org/en-US/docs/Mozilla/WebIDL_bindings#C_reflections_of_WebIDL_attributes
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Attachment #8856410 -
Flags: review?(kyle)
Comment 6•8 years ago
|
||
mozreview-review |
Comment on attachment 8856410 [details]
Bug 1350459 - Remove the [Throws] annotation from Window.navigator,
https://reviewboard.mozilla.org/r/128362/#review132634
Attachment #8856410 -
Flags: review?(kyle) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 8•8 years ago
|
||
Keywords: checkin-needed
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0bb5d2ed17ce
Remove the [Throws] annotation from Window.navigator, r=qdot
Keywords: checkin-needed
![]() |
||
Comment 10•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•