59 bytes, text/x-review-board-request
nsGlobalWindow::GetNavigator() never touches its aError argument, so we should be able to remove the [Throws] annotation.
Hi Ben, Wanna have some fun with this?
Sure. Take it.
Assignee: nobody → btian
The nsGlobalWindow::GetNavigator()  from Window.webidl  conflicts with the other nsGlobalWindow::GetNavigator()  from nsPIDOMWindow  if aError argument is removed. Additional integration effort is required. error: invalid covariant return type for ‘virtual mozilla::dom::Navigator* nsGlobalWindow::GetNavigator()’  http://searchfox.org/mozilla-central/source/dom/0  http://searchfox.org/mozilla-central/source/dom/1  http://searchfox.org/mozilla-central/source/dom/2  http://searchfox.org/mozilla-central/source/dom/3
Comment 3 conflict resolves since getter prefix "Get" is removed as no [Throws].  https://developer.mozilla.org/en-US/docs/Mozilla/WebIDL_bindings#C_reflections_of_WebIDL_attributes
Comment on attachment 8856410 [details] Bug 1350459 - Remove the [Throws] annotation from Window.navigator, https://reviewboard.mozilla.org/r/128362/#review132634
Attachment #8856410 - Flags: review?(kyle) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/0bb5d2ed17ce Remove the [Throws] annotation from Window.navigator, r=qdot
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.