Closed Bug 1350459 Opened 8 years ago Closed 8 years ago

Remove the [Throws] annotation from Window.navigator

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ben.tian)

Details

Attachments

(1 file)

nsGlobalWindow::GetNavigator() never touches its aError argument, so we should be able to remove the [Throws] annotation.
Hi Ben, Wanna have some fun with this?
Flags: needinfo?(btian)
Sure. Take it.
Assignee: nobody → btian
Flags: needinfo?(btian)
The nsGlobalWindow::GetNavigator() [1] from Window.webidl [2] conflicts with the other nsGlobalWindow::GetNavigator() [3] from nsPIDOMWindow [4] if aError argument is removed. Additional integration effort is required. error: invalid covariant return type for ‘virtual mozilla::dom::Navigator* nsGlobalWindow::GetNavigator()’ [1] http://searchfox.org/mozilla-central/source/dom/base/nsGlobalWindow.h#927 [2] http://searchfox.org/mozilla-central/source/dom/webidl/Window.webidl#70 [3] http://searchfox.org/mozilla-central/source/dom/base/nsGlobalWindow.h#928 [4] http://searchfox.org/mozilla-central/source/dom/base/nsPIDOMWindow.h#567
Comment 3 conflict resolves since getter prefix "Get" is removed as no [Throws]. [1] https://developer.mozilla.org/en-US/docs/Mozilla/WebIDL_bindings#C_reflections_of_WebIDL_attributes
Attachment #8856410 - Flags: review?(kyle)
Comment on attachment 8856410 [details] Bug 1350459 - Remove the [Throws] annotation from Window.navigator, https://reviewboard.mozilla.org/r/128362/#review132634
Attachment #8856410 - Flags: review?(kyle) → review+
Pushed by ihsiao@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0bb5d2ed17ce Remove the [Throws] annotation from Window.navigator, r=qdot
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: