Remove the [Throws] annotation from Window.navigator

RESOLVED FIXED in Firefox 55

Status

()

Core
DOM
RESOLVED FIXED
8 months ago
7 months ago

People

(Reporter: Away for a while, Assigned: btian)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

8 months ago
nsGlobalWindow::GetNavigator() never touches its aError argument, so we should be able to remove the [Throws] annotation.
Hi Ben,
Wanna have some fun with this?
Flags: needinfo?(btian)
(Assignee)

Comment 2

8 months ago
Sure. Take it.
Assignee: nobody → btian
Flags: needinfo?(btian)
(Assignee)

Comment 3

8 months ago
The nsGlobalWindow::GetNavigator() [1] from Window.webidl [2] conflicts with the other nsGlobalWindow::GetNavigator() [3] from nsPIDOMWindow [4] if aError argument is removed. Additional integration effort is required.

error: invalid covariant return type for ‘virtual mozilla::dom::Navigator* nsGlobalWindow::GetNavigator()’

[1] http://searchfox.org/mozilla-central/source/dom/base/nsGlobalWindow.h#927
[2] http://searchfox.org/mozilla-central/source/dom/webidl/Window.webidl#70
[3] http://searchfox.org/mozilla-central/source/dom/base/nsGlobalWindow.h#928
[4] http://searchfox.org/mozilla-central/source/dom/base/nsPIDOMWindow.h#567
(Assignee)

Comment 4

7 months ago
Comment 3 conflict resolves since getter prefix "Get" is removed as no [Throws].

[1] https://developer.mozilla.org/en-US/docs/Mozilla/WebIDL_bindings#C_reflections_of_WebIDL_attributes
Comment hidden (mozreview-request)
(Assignee)

Updated

7 months ago
Attachment #8856410 - Flags: review?(kyle)
Comment on attachment 8856410 [details]
Bug 1350459 - Remove the [Throws] annotation from Window.navigator,

https://reviewboard.mozilla.org/r/128362/#review132634
Attachment #8856410 - Flags: review?(kyle) → review+
Comment hidden (mozreview-request)
(Assignee)

Comment 8

7 months ago
Try result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9fc29f1b08c6
Keywords: checkin-needed

Comment 9

7 months ago
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0bb5d2ed17ce
Remove the [Throws] annotation from Window.navigator, r=qdot
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0bb5d2ed17ce
Status: NEW → RESOLVED
Last Resolved: 7 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.