nsIFrame::UpdateVisibilitySynchronously considers visibility: hidden as visible, but PresShell::MarkFramesInSubtreeApproximatelyVisible doesn't

RESOLVED FIXED in Firefox 55

Status

()

enhancement
RESOLVED FIXED
2 years ago
11 months ago

People

(Reporter: tnikkel, Assigned: tnikkel)

Tracking

Trunk
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

See bug 1312770, comment 53.

The difference stems from when this code was first landed. I'm not sure if I had a reason for that, but having these two pieces of code disagreeing is not what we want.
Posted patch patchSplinter Review
Attachment #8851147 - Flags: review?(mats)
Attachment #8851147 - Flags: review?(mats) → review+
Pushed by tnikkel@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/86e46eaaacfb
Consider visibility: hidden frames to be not visible in nsIFrame::UpdateVisibilitySynchronously to match PresShell::MarkFramesInSubtreeApproximatelyVisible. r=mats
https://hg.mozilla.org/mozilla-central/rev/86e46eaaacfb
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Core → Core Graveyard
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.