Closed Bug 1350463 Opened 4 years ago Closed 4 years ago

nsIFrame::UpdateVisibilitySynchronously considers visibility: hidden as visible, but PresShell::MarkFramesInSubtreeApproximatelyVisible doesn't

Categories

(Core :: Layout: Images, Video, and HTML Frames, enhancement)

Product:
Core
Component:
Layout: Images, Video, and HTML Frames
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: tnikkel, Assigned: tnikkel)

References

Details

Attachments

(1 file)

patch
1.10 KB, patch
mats
: review+
Details | Diff | Splinter Review 
See bug 1312770, comment 53.

The difference stems from when this code was first landed. I'm not sure if I had a reason for that, but having these two pieces of code disagreeing is not what we want.
Attached patch patch — — Splinter Review
Attachment #8851147 - Flags: review?(mats)
Attachment #8851147 - Flags: review?(mats) → review+
Pushed by tnikkel@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/86e46eaaacfb
Consider visibility: hidden frames to be not visible in nsIFrame::UpdateVisibilitySynchronously to match PresShell::MarkFramesInSubtreeApproximatelyVisible. r=mats
https://hg.mozilla.org/mozilla-central/rev/86e46eaaacfb
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Core → Core Graveyard
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.