Closed Bug 1350499 Opened 6 years ago Closed 6 years ago

Different width/height shown in editbox of boxmodel-content

Categories

(DevTools :: Inspector, defect, P3)

defect

Tracking

(firefox52 unaffected, firefox53 unaffected, firefox54 unaffected, firefox55 verified)

VERIFIED FIXED
Firefox 55
Tracking Status
firefox52 --- unaffected
firefox53 --- unaffected
firefox54 --- unaffected
firefox55 --- verified

People

(Reporter: magicp.jp, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Steps to Reproduce:
1. Start latest Nightly (e.g. Build ID:20170324030205)
2. Go to about:home
3. Open Inspector > Computed
4. Select #aboutMozilla in markup
5. Click width/height on boxmodel-content

Actual Result:
Different width/height is shown. (It seems #aboutMozilla::before size?)
Please refer to attached image.


Expected Result:
Is this intentionally? If not, own width/height is shown as default when editing.
Has STR: --- → yes
Priority: -- → P3
We actually have the same issue with margin/border/padding etc...

If a pseudo-element defines a value for any of those properties, and the element itself doesn't, the editing session will pick up the value from the pseudo element.
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Comment on attachment 8852475 [details]
Bug 1350499 - exclude styles for pseudo-els when building boxmodel widget;

https://reviewboard.mozilla.org/r/124680/#review127246

::: devtools/client/inspector/boxmodel/test/browser_boxmodel_editablemodel_pseudo.js:10
(Diff revision 1)
> +"use strict";
> +
> +// Test that pseudo elements have no side effect on the box model widget for their
> +// container. See bug 1350499.
> +
> +const TEST_URI = "<style>" +

We should just use multiline strings here
Attachment #8852475 - Flags: review?(gl) → review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1f74f77a9814
exclude styles for pseudo-els when building boxmodel widget;r=gl
https://hg.mozilla.org/mozilla-central/rev/1f74f77a9814
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
I have verified this bug was fixed in latest Nightly build (20170410030221). Thanks!
Status: RESOLVED → VERIFIED
[bugday-20170412] 
The bug is no longer to be reproducible in Latest Nightly 55.0a1.
OS:Windows 10
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.