1350499 - Different width/height shown in editbox of boxmodel-content

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P3)

Description

[magicp]

Attachment: Different-width-height-shown-in-editbox-of-boxmodel-content.png

Steps to Reproduce:
1. Start latest Nightly (e.g. Build ID:20170324030205)
2. Go to about:home
3. Open Inspector > Computed
4. Select #aboutMozilla in markup
5. Click width/height on boxmodel-content

Actual Result:
Different width/height is shown. (It seems #aboutMozilla::before size?)
Please refer to attached image.


Expected Result:
Is this intentionally? If not, own width/height is shown as default when editing.

Comment 1

[Julian Descottes [:jdescottes]]

We actually have the same issue with margin/border/padding etc...

If a pseudo-element defines a value for any of those properties, and the element itself doesn't, the editing session will pick up the value from the pseudo element.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1350499 - exclude styles for pseudo-els when building boxmodel widget;

Review commit: https://reviewboard.mozilla.org/r/124680/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/124680/

Comment 3

[Gabriel [:gl] (ΦωΦ)]

Comment on attachment 8852475 [details]
Bug 1350499 - exclude styles for pseudo-els when building boxmodel widget;

https://reviewboard.mozilla.org/r/124680/#review127246

::: devtools/client/inspector/boxmodel/test/browser_boxmodel_editablemodel_pseudo.js:10
(Diff revision 1)
> +"use strict";
> +
> +// Test that pseudo elements have no side effect on the box model widget for their
> +// container. See bug 1350499.
> +
> +const TEST_URI = "<style>" +

We should just use multiline strings here

Comment 4

[Julian Descottes [:jdescottes]]

Comment on attachment 8852475 [details]
Bug 1350499 - exclude styles for pseudo-els when building boxmodel widget;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/124680/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f74f77a9814
exclude styles for pseudo-els when building boxmodel widget;r=gl

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1f74f77a9814

Comment 7

[magicp]

I have verified this bug was fixed in latest Nightly build (20170410030221). Thanks!

Comment 8

[Fahima Zulfath]

[bugday-20170412] 
The bug is no longer to be reproducible in Latest Nightly 55.0a1.
OS:Windows 10