1350527 - DownloadInterrupt should be processed

Status: NEW

(Testing :: mozregression, enhancement)

Description

[YF (Yang)]

On https://github.com/mozilla/mozregression/blob/master/mozregression/download_manager.py.


e.g. When I interrupt a connection through proxy manager to analog or make connection interruption (such as switching the connection output proxy), I will receive the following logs:
2017-03-25T17:02:14: INFO : Running mozilla-central build for 2014-07-21
2017-03-25T17:02:14: ERROR : Unable to install 'xxxx\\2014-07-21--mozilla-central--firefox-34.0a1.en-US.win32.zip'

And a corrupted package, and then be prompted that you have ignored the build, need to choose a nearby build version.

Comment 1

[William Lachance (:wlach)]

Sounds like a valid issue, would you be interested in working on this?

Comment 2

[YF (Yang)]

(In reply to William Lachance (:wlach) (use needinfo!) from comment #1)
> Sounds like a valid issue, would you be interested in working on this?

nothing now.

Comment 3

[Hrushikesh Bodas]

Hi I am a new contributor and i wish to work on this issue.I have read the introductory documents from the mozilla page. How do i get started for this particular bug? Can i get some technical knowledge on this?
:wlach

Comment 4

[YF (Yang)]

I expect the "class DownloadInterrupt(Exception):" to throw an error and continue to the appropriate retry or error log instead of "pass" and "_download_finished". Sorry I have no more information.

Comment 5

[Hrushikesh Bodas]

Sorry... Couldnt take this up then. Can I take up this bug?

Comment 6

[Hrushikesh Bodas]

I am a bit confused about the bug. I have a few questions.
#1 In what case does the DownloadInterrupt class need to throw an exception? Currently, that class is only called when download is canceled. otherwise an error is raised. 
#2 Does the class need to log these errors?

Comment 7

[YF (Yang)]

(In reply to Hrushikesh Bodas from comment #6)
> I am a bit confused about the bug. I have a few questions.
> #1 In what case does the DownloadInterrupt class need to throw an exception?
> Currently, that class is only called when download is canceled. otherwise an
> error is raised. 
> #2 Does the class need to log these errors?

I have encountered it many times when using an unstable proxy server. This should be able to be simulated by interrupting the connection.

Comment 8

[Hrushikesh Bodas]

Assignee: [e-mail] → [e-mail]

Comment 9

[vaibhgupt199]

Hi, I am new here. Can you please tell me that what you mean by `This should be able to be simulated by interrupting the connection."

Comment 10

[YF (Yang)]

(In reply to vaibhgupt199 from comment #9)
> Hi, I am new here. Can you please tell me that what you mean by `This should
> be able to be simulated by interrupting the connection."

Use a proxy server software, or agent handler (like "Proxifier"), close it when downloading.

Comment 11

[anandvardhan371]

could i be assigned this bug i am a new to open source i want to give it a try

Comment 12

[William Lachance (:wlach)]

(In reply to anandvardhan371 from comment #11)
> could i be assigned this bug i am a new to open source i want to give it a
> try

Please go ahead! To reduce churn I tend not assign bugs, but we can take this comment thread as an indication that you're looking into it.

Unfortunately I am too busy these days to mentor mozregression bugs explicitly, but I am happy to review a working patch. I haven't investigated the details of what would be involved here.