1350579 - JS_ExecuteRegExpNoStatics() is heavily broken

Status: RESOLVED INCOMPLETE

(Core :: JavaScript Engine, defect, P3)

Description

[(no longer active)]

While working on bug 1347425, I tried to use JS_ExecuteRegExpNoStatics() in a similar manner to how it's used in nsContentUtils::IsPatternMatching() <http://searchfox.org/mozilla-central/rev/7419b368156a6efa24777b21b0e5706be89a9c2f/dom/base/nsContentUtils.cpp#6814>, and it seemed to work, and the test we had in the tree with the regular expression to match passed: <http://searchfox.org/mozilla-central/rev/7419b368156a6efa24777b21b0e5706be89a9c2f/netwerk/test/mochitests/test_user_agent_overrides.html#26>.

And then I tried adding a similar test with a different regex!  This time, "0".  That didn't work.  I narrowed it down to ExecuteRegExpImpl <http://searchfox.org/mozilla-central/rev/7419b368156a6efa24777b21b0e5706be89a9c2f/js/src/builtin/RegExp.cpp#153> returning RegExpRunStatus_Success_NotFound.  The string in which I was searching was "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:55.0) Gecko/20100101 Firefox/55.0".

I then tried "zilla".  That one worked.  "illa" didn't.  "[0-9]+" din't either...  This code is being used for several use cases but in every case for full string matches (i.e., "^(...)$"), so I hope whatever the underlying cause ends up being doesn't affect that, but at this is at least worth investigation given the fact that we're shipping code relying on this function.  :(

Comment 1

[(no longer active)]

Attachment: The patch from bug 1347425 that adds the code that allows an easy way to test this

After applying this patch, you can build with it, then edit this test and change the regex on line 26 of netwerk/test/mochitests/test_user_agent_overrides.html to "illa".

Comment 2

[Avikalpa Kundu [:kalpa]]

Hello,

Will it be okay if I work on this bug?

Comment 3

[(no longer active)]

Yes, by all means! :-)

Comment 4

[Avikalpa Kundu [:kalpa]]

(In reply to :Ehsan Akhgari (super long backlog, slow to respond) from comment #3)
> Yes, by all means! :-)

Thanks

Can you assign me this bug then?

Comment 5

[(no longer active)]

Here you go!  I'll also grant you editbugs access so that you can you can do this yourself the next time you were interested to fix a bug.  :-)

(BTW sorry for the long delay to get back to you.)

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.