1350582 - Add a CI task to (just) build with both optimization and debugging disabled on our main platforms

Status: RESOLVED DUPLICATE of bug 1341404

(Firefox Build System :: General, enhancement)

Description

[Jonathan Watt [:jwatt]]

On Mac debug builds run so slowly nowadays it's virtually impossible to get things done. I've come to the conclusion I generally need to build with --disable-debug to be productive, but then I don't want optimizations to mess with the debugger. Hence I'm trying to build with both debug and optimization disabled. That is:

  ac_add_options --disable-debug --disable-optimize

Unfortunately I just encountered a build error with that configuration (bug 1350581). Apparently this happens not infrequently because we don't have a build machine that tests this configuration. Can we add one please?

Comment 1

[Andrew McCreight [:mccr8]]

I think that by default both opt and debug builds have optimization enabled. So I'm not sure if we test any configuration with optimization disabled.

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This isn't something Treeherder would do.

Comment 3

[Jonathan Watt [:jwatt]]

Nathan, would you be able to get this a step closer to happening? Or all the way... ;)

Comment 4

[Justin Wood (:Callek)]

To be clear, from IRC:

This bug is about making the combination of mozconfig options actually result in a successful (local) build, and has nothing to do with changing actual CI Automation to utilize those options.

Comment 5

[Jonathan Watt [:jwatt]]

It's about making sure that bustage of:

  ac_add_options --disable-debug --disable-optimize

shows up on treehearder and gets backed out.

It seems to me that involves adding builds that use those options (one for windows, one for mac and one for linux would do I think, and I don't care if they run tests). I'd have thought adding new builds counts as "changing actual CI Automation", but maybe you're using that phrase to mean changing the tools, or something.

Comment 6

[Justin Wood (:Callek)]

(In reply to Jonathan Watt [:jwatt] from comment #5)
> It's about making sure that bustage of:
> 
>   ac_add_options --disable-debug --disable-optimize
> 
> shows up on treehearder and gets backed out.
> 
> It seems to me that involves adding builds that use those options (one for
> windows, one for mac and one for linux would do I think, and I don't care if
> they run tests). I'd have thought adding new builds counts as "changing
> actual CI Automation", but maybe you're using that phrase to mean changing
> the tools, or something.

Ahhh this was me, misunderstanding the desire here.

So whats needed is

(*) someone fixing the bustage of this
(*) Someone adding the tasks to the tree in some acceptable cadence (if agreed as a desire).

If this bug is indeed about the second piece, this *does* belong in releng.  I'm going to n-i catlee to quantify that its both something we want to do and to see how it fits on priorities.

Comment 7

[Chris AtLee [:catlee]]

I think the build team is best suited to answering whether we *should* do this. Should this be a supported configuration?

If the answer is yes, then the build team is also best suited to modifying the task graphs to create and maintain these jobs.

Comment 8

[Jonathan Watt [:jwatt]]

(In reply to Andrew McCreight [:mccr8] from comment #1)
> I think that by default both opt and debug builds have optimization enabled.
> So I'm not sure if we test any configuration with optimization disabled.

Indeed, which is why the following wasn't picked up by our build infrastructure:

https://bugzilla.mozilla.org/show_bug.cgi?id=1364727#c22

Comment 9

[Nathan Froyd [:froydnj]]

Going to duplicate this, since the dup bug will have builds added for desktop tier 1 platforms.