WebExtensions: reloading a sidebar extension on about:debugging closes sidebar

RESOLVED FIXED in Firefox 55

Status

()

Toolkit
WebExtensions: Frontend
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: Geoffrey De Belie (Smile4ever), Assigned: mixedpuppy)

Tracking

54 Branch
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: triaged)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

5 months ago
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID: 20170314110401

Steps to reproduce:

1) Load a WebExtension that uses the sidebar API on about:debugging
"sidebar_action": {
  "default_icon": "icons/icon.png",
  "default_title" : "Sidebar",
  "default_panel": "sidebar.html"
}
-> A sidebar opens

2) Press the button reload
-> The sidebar closes and doesn't open again!



Expected results:

The sidebar should re-open after the extension is reloaded.

Updated

5 months ago
Component: WebExtensions: Untriaged → WebExtensions: Frontend
(Assignee)

Comment 1

4 months ago
I was about to wont-fix this, however this also affects addon upgrade from AMO.
Assignee: nobody → mixedpuppy
Status: UNCONFIRMED → NEW
Ever confirmed: true
Whiteboard: triaged
Comment hidden (mozreview-request)

Comment 3

4 months ago
mozreview-review
Comment on attachment 8858398 [details]
Bug 1350597 fix reload/upgrade of sidebar addon,

https://reviewboard.mozilla.org/r/130346/#review133064

::: browser/components/extensions/ext-sidebarAction.js:104
(Diff revision 1)
>    build() {
>      this.tabContext.on("tab-select", // eslint-disable-line mozilla/balanced-listeners
>                         (evt, tab) => { this.updateWindow(tab.ownerGlobal); });
>  
>      let install = this.extension.startupReason === "ADDON_INSTALL";
> +    let upgrade = this.extension.startupReason === "ADDON_UPGRADE";

Should also accept ADDON_DOWNGRADE.
Attachment #8858398 - Flags: review?(kmaglione+bmo) → review+
Comment hidden (mozreview-request)

Comment 5

4 months ago
Pushed by mixedpuppy@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/45f5b5a65b7f
fix reload/upgrade of sidebar addon, r=kmag
https://hg.mozilla.org/mozilla-central/rev/45f5b5a65b7f
Status: NEW → RESOLVED
Last Resolved: 4 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.