1350597 - WebExtensions: reloading a sidebar extension on about:debugging closes sidebar

Status: RESOLVED FIXED

(WebExtensions :: Frontend, defect)

Description

[Geoffrey De Belie (Smile4ever)]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID: 20170314110401

Steps to reproduce:

1) Load a WebExtension that uses the sidebar API on about:debugging
"sidebar_action": {
  "default_icon": "icons/icon.png",
  "default_title" : "Sidebar",
  "default_panel": "sidebar.html"
}
-> A sidebar opens

2) Press the button reload
-> The sidebar closes and doesn't open again!



Expected results:

The sidebar should re-open after the extension is reloaded.

Comment 1

[Shane Caraveo (:mixedpuppy)]

I was about to wont-fix this, however this also affects addon upgrade from AMO.

Comment 2

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1350597 fix reload/upgrade of sidebar addon,

Review commit: https://reviewboard.mozilla.org/r/130346/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/130346/

Comment 3

[Kris Maglione [:kmag]]

Comment on attachment 8858398 [details]
Bug 1350597 fix reload/upgrade of sidebar addon,

https://reviewboard.mozilla.org/r/130346/#review133064

::: browser/components/extensions/ext-sidebarAction.js:104
(Diff revision 1)
>    build() {
>      this.tabContext.on("tab-select", // eslint-disable-line mozilla/balanced-listeners
>                         (evt, tab) => { this.updateWindow(tab.ownerGlobal); });
>  
>      let install = this.extension.startupReason === "ADDON_INSTALL";
> +    let upgrade = this.extension.startupReason === "ADDON_UPGRADE";

Should also accept ADDON_DOWNGRADE.

Comment 4

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8858398 [details]
Bug 1350597 fix reload/upgrade of sidebar addon,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/130346/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45f5b5a65b7f
fix reload/upgrade of sidebar addon, r=kmag

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/45f5b5a65b7f